Cleanup into()'s about syncstorage-rs HOT 3 OPEN

JIRA

from syncstorage-rs.

I think the first couple suggestions are worth pursuing however I don't think we can easily kill ErrorKind enums as it would complicate our inclusion of a backtrace field (and any other fields such as tags) on Errors.

from syncstorage-rs.

Ah I see what you mean for ApiError, but it looks like it might be possible to get rid of DbErrorKind and ValidationErrorKind? The only field besides kind in DbError and ValidationError is status, and I think we could implement that as a method on the type itself, since it's computed from kind. Something like:

enum DbError {
    ...
}

impl DbError {
    fn status(&self) -> StatusCode {
        match self.kind {
            ...
        }
    }
}

(I think Tags are only stored in the request extensions from what I can tell)

from syncstorage-rs.