Giter VIP home page Giter VIP logo

Comments (3)

thomcc avatar thomcc commented on June 26, 2024 1

Please be careful here WRT off by one errors. The clients expect MAX to be the highest valid value of these (see mozilla-services/server-syncstorage#74 and mozilla-services/server-syncstorage#73).

If it helps at all, the Desktop JS code is fairly well commented in terms of explaining what the client expects from the limits.

(And yeah, I don't think there's any way you can enforce the _BYTES limits except for manually, since they refer to a subset of the bytes in the requests)

from syncstorage-rs.

pjenvey avatar pjenvey commented on June 26, 2024

#104 began enforcing all these limits except the 2 batch settings max_total_{bytes/records}

from syncstorage-rs.

pjenvey avatar pjenvey commented on June 26, 2024

max_total_{bytes/records} are now checked as of #108.

Logged a somewhat related #114 for further enhancements from the go version.

from syncstorage-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.