adapt for tokio-uds 0.2.0 about audioipc HOT 8 CLOSED

It looks like tokio-uds will need additional changes before we can update to it. need_read and need_write have been removed from UnixStream and the replacement clear_read_ready and clear_write_ready haven't been exposed publicly.

from_stream has been renamed to from_std, but it also takes a different Handle type, so we may have to move all of our Tokio use to the newer version to make progress on this.

from audioipc.

from audioipc.

Fortunately it's not the big tokio/futures 0.2 change, just the earlier tokio reform work that introduced the top-level tokio 0.1 crate.

It turns out there's a compat shim for tokio Handle types, so it's possible to convert the old-style tokio_core Handle into a new tokio_reactor Handle via new_tokio_handle().

It seems like that's the only additional change necessary to compile, so I've pushed a branch to https://github.com/djg/audioipc-2/tree/tokio_uds_020. Note that it does rely on a modified tokio_uds that reexports clear_read_ready and clear_write_ready.

ipctest doesn't complete with this branch, so there are still fixes needed somewhere.

from audioipc.

i only see a single commit on the tokio_uds_020 branch.. is it the one that's supposed to build with tokio-uds 0.2.0 ? seems the same as the ctest branch.

As for reexporting clear_{read,write}_ready, how can this be handled ? fixed upstream in the merged tokio repo ?

from audioipc.

i only see a single commit on the tokio_uds_020 branch.. is it the one that's supposed to build with tokio-uds 0.2.0 ? seems the same as the ctest branch.

Sorry. I've pushed the actual changes now.

As for reexporting clear_{read,write}_ready, how can this be handled ? fixed upstream in the merged tokio repo ?

That change needs to go in to tokio-uds. I'll send a PR soon and see what happens.

from audioipc.

@kinetiknz Any news on this ? tokio-uds is the last thing pulling log 0.3.9 in m-c

from audioipc.

I have a working build using tokio 0.1 and tokio-uds 0.2 (with minor local changes) now. Working on getting this merged.

from audioipc.

Done via #64.

from audioipc.