Comments (7)
docs/index.rst says you'll need a less compiler, but I think you shouldn't need that unless you want to compile/minify CSS for deployment.
Btw, just adding the LESS script to the template does not seem to work, I think that's a bug in jingo-minify, it fails to set rel="stylesheet/less"
for less files so the script does not pick up those files. Sounds fixable :)
from bedrock.
I mentioned the exact same thing to jsocol, and he pointed out that it's actually type="text/less"
that need to be set (I think). Regardless, we probably should make this work. I like the fact that it compiles it server-side so that it's not always having to dynamically parse LESS, but it is annoying to have node as a requirement.
We can include the js compiler and spit out the appropriate markup if the node compiler isn't installed. I'll poke around jingo-minify to see if there's a way to get it to spit out the right rel
or type
, whichever's needed.
from bedrock.
Thanks!
lesscss.org says: <link rel="stylesheet/less" type="text/css" href="styles.less">
from bedrock.
I also agree that precompiling is neat, but I think that's something optional. We could insert the JS compiler iff the PREPROCESS setting is set to False (and TEMPLATE_DEBUG=True, of course), otherwise let node do its thing.
from bedrock.
FWIW, I upstreamed this issue to jingo-minify: jsocol/jingo-minify#20
from bedrock.
Cool. We had a few more problems doing it server-side, so I would like to see this happen. I can try to get this done next week.
from bedrock.
Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=738406
from bedrock.
Related Issues (20)
- Newsletter "from" suggestion mismatch HOT 2
- Remove all instances of data-cta-type="button" or "link" HOT 1
- Change _fxa_product_button macro to automatically insert data-cta-type ?? HOT 1
- Tools 404 HOT 1
- Removed sanity tests still referenced HOT 1
- Add signal handler to alert when translations land, so they can be published HOT 8
- Update the postgres-to-sqlite-export script to be a lot more cautious
- Support CAT tool in Smartling, including support for draft/unpublished pages if possible
- [GTM Review] Review GTM space "data-link-name" HOT 1
- Home for outdated locales interacts badly with donate banner HOT 1
- [nothing personal] Create vanity URL w/o a dash + a redirect
- WNP 130 EU + NA – Duplicate Tabs
- Support automatic linting of translated content HOT 5
- FXDE in-product pages include navbar HOT 1
- A11y fixes for home form & nav roles HOT 3
- Remove experiment from Welcome 15 HOT 2
- Remove july2024 fundraising banner experiment HOT 1
- mdx_outline now released with mozmeao updates HOT 2
- CTD links not pointing to the CTD page
- [GTM Review] Review and publish GTM workspace GA3 deletions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bedrock.