Giter VIP home page Giter VIP logo

Comments (4)

danielhertenstein avatar danielhertenstein commented on June 18, 2024 1

@biancadanforth, I think you are right. I am able to create vectors for the shopping set with a regular HTTP server. The only thing I can think of is that I was loading pages through my file explorer (using file:///) when I was testing the extractor's correctness, and so was unnecessarily causing the CORS restrictions. That would be frustrating and embarrassing for me, though it would be good news for Fathom.

from fathom-fox.

erikrose avatar erikrose commented on June 18, 2024 1

I second. https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS/Errors/CORSRequestNotHttp says CORS requests must be HTTPS, but we're not dealing with CORS requests as long as we avoid file URLs: the host and port are the same for all requests.

from fathom-fox.

erikrose avatar erikrose commented on June 18, 2024

Since we chatted on IRC a few hours ago, I recalled that there are several CORS-controlling about:config flags (search for "cors" and "cross"). It's pretty heavy to start [automatically] installing brew packages. Maybe we can just twiddle those flags more easily? Of course, I (like you) am assuming we're not messing with the user's primary browser.

from fathom-fox.

biancadanforth avatar biancadanforth commented on June 18, 2024

You know, I was thinking more about it Friday, and I am wondering... @danielhertenstein , Why do we need an HTTPS server? If we have a local HTTP server, the browser should treat that as http:// protocol, not file:/// protocol I should think.

I just tried a regular HTTP server via python3 -m http.server 8000 --bind 127.0.0.1 for the Vectorizer step at least, and the pages loaded normally, and it produced the same vectors.json file as with the HTTPS server via fathom-serve. Maybe I am missing something?

from fathom-fox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.