Combine efforts with rust-nightly-nix about nixpkgs-mozilla HOT 15 CLOSED

I think merging in rust-nightly-nix into nixpkgs-mozilla is the direction we should be going for.

from nixpkgs-mozilla.

@zimbatm , I was discussing that with @Havvy on #nixos irc.mozilla.org, and the manifest file explicitly list all rust-std targets as being inside the rust package, such as wasm32-unknown-emscripten and x86_64-unknown-linux-musl.

So I have not tested it, but I am confident it should work out of the box.

from nixpkgs-mozilla.

This issue is now out of date, see solson/rust-nightly-nix#27 for a summary of the situation.

from nixpkgs-mozilla.

💯 from my side, @solson would you be able to provide a PR then @nbp as current author of rust overlay (we don't want to break nobodies workflow).

Of-course you'll get a push permission with merged PR :)

And this reminds me: I need to setup binary cache for this repo.

from nixpkgs-mozilla.

Well, it's not yet clear to me at least what parts form each we want :). But yes PR in the end would be good.

from nixpkgs-mozilla.

should we organize a quick google hangout to discuss how to move forward with this? ping to @solson @Ericson2314 @Havvy @nbp

from nixpkgs-mozilla.

Most of us on the nix-nightly-rust side hang out in the Rust IRC channels (and #nixos on Freenode).

from nixpkgs-mozilla.

I could do either, but I will be on vacation for about a week starting Thursday.

from nixpkgs-mozilla.

@Havvy wrote:

I think merging in rust-nightly-nix into nixpkgs-mozilla is the direction we should be going for.

I carefully did not look too much into @solson work, because of the licensing issue.

Instead, I reversed engineered rustup and annotated the code of the the rust-overlay to take rustup as the only source of truth.

I also think this repository should be using MIT instead of the MPL, such that we can at least contribute back to Nixpkgs.

@Havvy wrote:

Most of us on the nix-nightly-rust side hang out in the Rust IRC channels (and #nixos on Freenode).

You can find me on both freenode (pierron) and irc.mozilla.org (nbp).

from nixpkgs-mozilla.

Looking at the differences:

• The rust overlay uses the manifest v2 like rustup, instead of the manifest v1 (deprecated?).
• Binaries are patched by finding them, instead of listing them.
• Uses the install script provided in the tarball instead of using rsync.
• Provides "stable", "beta", and "nightly" like rustup, instead of only "nightly" builds.
• The rust overlay has no equivalent to rustcWithSysroots function.
• The rust overlay does not use multiple outputs.

from nixpkgs-mozilla.

What's the story around cross-compilation, does either support it?

from nixpkgs-mozilla.

With rust-nightly-nix, you need to use rustc-with-sysroots and list which cross-compilation targets you want to support. I have actually done this, so I know it works.

from nixpkgs-mozilla.

From what I can tell, the only missing part now seems to be the documentation of the Rust overlay.
Especially how to use it with the existing Nixpkgs infrastructure, and how to use it for cross-compiling.

from nixpkgs-mozilla.

That matches my understanding of the situation too.

from nixpkgs-mozilla.

And for the record, cross compilation was also fixed.

from nixpkgs-mozilla.