Rust overlay: cannot find bash completion files about nixpkgs-mozilla HOT 7 CLOSED

Ran into the same problem while trying to install nixos.rustChannels.stable.rust (1.18.0). nixos.rustChannels.nightly.rust (1.20.0) works perfectly.

Installing on top of the stable NixOS branch (17.03.1461.ebeb8901a2 (Gorilla))

from nixpkgs-mozilla.

@aepsil0n I suppose it doesn't hurt if we check for 2 more folders :)
Thank you @rexim for the PR

from nixpkgs-mozilla.

It turns out the directory is actually called bash_completions.d (note the plural). I really wonder how the name changed…

from nixpkgs-mozilla.

After reading the comments of @aepsil0n I made the following changes rexim@466ae2d And now it works on stable but doesn't work on nightly. :)

Maybe we should check for both bash_compeition and bash_completions and take actions according to which one exists?

from nixpkgs-mozilla.

@rexim 👍 could you create a PR for this? eg. loop over all the folders ("etc/bash_completion.d","share/bash_completion/completions","etc/bash_completions.d","share/bash_completions/completions";) and then break out of the loop if $paths does not exists? eg.

for paths in "etc/bash_completion.d","share/bash_completion/completions","etc/bash_completions.d","share/bash_completions/completions"; do
  if [ ! -e $paths ]; then continue; fi
  ...
done

And maybe add a comment with a link to this issue.

EDIT: please add me as a reviewer (or ping me) and I will look at it asap.

from nixpkgs-mozilla.

@garbas I have a pretty limited amount of resources but I will try to do something in the nearest future. If I don't submit PR in three days, consider me not working on that. :)

from nixpkgs-mozilla.

Thanks for the PR!

Interestingly, now that Rust 1.19 was released yesterday, the issue magically disappeared. I wonder, whether we should still address the issue, just in case one wants to build an old version at some point?

from nixpkgs-mozilla.