Prevent reassignment of req.session about node-client-sessions HOT 5 CLOSED

Hey guys, I'm new to this library, and have a naive question: why are Harmony proxies needed by this middleware at all? Can't it just take the session object and serialize it when the request headers are sent? Why does it need to do something anytime a session property is set/etc.?

from node-client-sessions.

Ah I see from #42 that it gives a performance win, since encryption is expensive. If that's it, thanks.

from node-client-sessions.

Exactly, in order to keep requests as fast as possible, the cookie is only re-encrypted when it needs to be.

from node-client-sessions.

Is there a hybrid option here? Only re-encrypt on changes, but check before each response if the session object has been reassigned, and if so, re-encrypt?

from node-client-sessions.

Well, if it's reassigned, it is no longer a Proxy. Then we can no longer watch if properties change. Maybe we could use a setter for the property on req to iterate over the newly assigned object, and set each property on the proxy.

Object.defineProperty(req, requestKey, {
  set: function(val) {
    // clear all keys from proxy
    // for key in val
       // proxy[key] = val[key];
  }
});

But I dunno, just thinking aloud.

from node-client-sessions.