BigTent needs to support routing requests through an HTTP(S) proxy about persona-yahoo-bridge HOT 11 CLOSED

My understanding was

a) We can proxy requests through Squid at the OS level
b) We'll try to add proxy support as a possible load testing strategy, but we have other, more promising routes.

from persona-yahoo-bridge.

@fetep, care to weigh in? It was my understanding that we can't do this at the OS / VM level?

callahad: Okay, it looks like this is going to require patching node-openid and node-oauth. Do you know if there's any way to alternatively do this at the VM level?
petef: there's not

from persona-yahoo-bridge.

Yeah, this should really happen at the code level. We'd have to switch to having a transparent proxy and do a bunch of fancy and hard to debug network tricks to make it work, and I'd prefer not to do that in production.

from persona-yahoo-bridge.

@ozten, I think we discussed writing a local proxy that we could point the code at for mocking the services we talk to, but either way, the code needs to support talking through a proxy.

from persona-yahoo-bridge.

Plan for OpenID based services.

1. Fork node-openid
2. Add proxy support to 0.2.x version of node-openid
3. Fork passport-google and passport-yahoo
4. Point them to our fork of node-openid
5. Work on upstreaming these changes

1 is at https://github.com/ozten/node-openid

from persona-yahoo-bridge.

Filed a node-oauth issue to capture the same request upstream.

Next steps for passport-windowslive:

1. Fork node-oauth
2. Add proxy support to 0.9.x version of node-oauth
3. Fork passport-windowslive and passport-oauth
4. Point it to our fork of node-oauth
5. Work on upstreaming these changes

from persona-yahoo-bridge.

Okay, I think this is fixed. Of course some of the steps documented here still need to happen to get us back on upstream, but closing this bug to make sure @fetep and @callahad are good to go.

Please re-open and comment if there are any issues.

from persona-yahoo-bridge.

Working with @havard I'm changing the env variables to:

export HTTP_PROXY_HOST=localhost
export HTTP_PROXY_HOST=8080
export HTTPS_PROXY_HOST=localhost
export HTTPS_PROXY_HOST=8443

No update from node-oauth people yet.

from persona-yahoo-bridge.

@fetep - Will Squid, etc rewrite the request path before proxying traffic?

We should test this in Stage soon.

Issue - In the current code I update path to an absolute URL. This works for Google, but Windows live was sending back a 400. In my passthrough proxy, I now rewrite the absolute URL to a relative URL, which makes Windows Live happy again.

This fix was in my pass through proxy which I use to manually test the proxy config, so I want to make sure Squid will also send relative urls... the other option is that changing path and the Host header isn't quite right in these proposed patches, which would be a bigtent code change.

from persona-yahoo-bridge.

@gene1wood You'll want to weight in on this bug as well as reading

• havard/node-openid#83
• ciaranj/node-oauth#102

Thanks!

from persona-yahoo-bridge.

I think we're good, closing, but @gene1wood don't hesitate with questions or feedback.

from persona-yahoo-bridge.