Giter VIP home page Giter VIP logo

Comments (3)

rfk avatar rfk commented on June 15, 2024

Thanks for checking on this. PyBrowserID uses the requests library, which is supposed to do the verification automatically and transparently. See here, where we pass in verify=True:

https://github.com/mozilla/PyBrowserID/blob/master/browserid/netutils.py#L23

Technically I think this is unnecessary, as "verify" defaults to True per the docs here:

http://www.python-requests.org/en/latest/user/advanced/#ssl-cert-verification

But I put it in explicitly in case anyone fiddles with the defaults and we don't notice.
Can you suggest any ways to do this better or more thoroughly?

from pybrowserid.

jessaustin avatar jessaustin commented on June 15, 2024

https://github.com/kennethreitz/requests/issues/1659 might be relevant to this discussion?

from pybrowserid.

rfk avatar rfk commented on June 15, 2024

It's not clear to me what more needs to be done here on the PyBrowserID side, if anything. Tentatively closing this but please re-open it with more details if I've missed anything.

from pybrowserid.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.