Comments (3)
Thanks for checking on this. PyBrowserID uses the requests library, which is supposed to do the verification automatically and transparently. See here, where we pass in verify=True:
https://github.com/mozilla/PyBrowserID/blob/master/browserid/netutils.py#L23
Technically I think this is unnecessary, as "verify" defaults to True per the docs here:
http://www.python-requests.org/en/latest/user/advanced/#ssl-cert-verification
But I put it in explicitly in case anyone fiddles with the defaults and we don't notice.
Can you suggest any ways to do this better or more thoroughly?
from pybrowserid.
https://github.com/kennethreitz/requests/issues/1659 might be relevant to this discussion?
from pybrowserid.
It's not clear to me what more needs to be done here on the PyBrowserID side, if anything. Tentatively closing this but please re-open it with more details if I've missed anything.
from pybrowserid.
Related Issues (18)
- Don't accept assertions signed by a fallback if the domain is an IDP
- remove fallback to /pk
- deprecate "old-style" format for bundled assertions
- Python 3 compatibility HOT 4
- less cryptic errors : let's verify the data HOT 2
- Intermittent exception from encode_bytes() HOT 1
- add support for unverified addresses? HOT 2
- DSKey objects should be able to calculate y from x
- LocalVerifier and the verifier running at https://verifier.login.persona.org/verify sign differently HOT 2
- LocalVerifier does not trust gmail / yahoo root issuers HOT 1
- error on url fetch
- Consider switching to cryptography.io HOT 3
- announcement: Python 2/3 compatibility
- CODE_OF_CONDUCT.md file missing
- do not hard depend on mock
- Add open source software license HOT 1
- Dont follow redirects when loading support document(?)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pybrowserid.