Deadlock: trying to open a store while a writer is in progress about rkv HOT 6 CLOSED

Nice catch!

We do currently document the potential for a call to Store::write() to block on an extant Writer (in the Basic Usage example and the Store::write() API reference). However, we don't currently document that Rkv::open_or_create() will also block on an extant Writer, given the details of the underlying implementation. And that'll trip up API consumers. So we should definitely document it (and perhaps research ways to fix or work around the limitation, if it's feasible to do so).

from rkv.

This also reminds me that we should also allow a store to be opened in the read_only mode. Doing so allows the consumer to open the store to read while there is an in-flight write transaction on the same store.

This might require some changes in lmdb-rs.

from rkv.

This might require some changes in lmdb-rs.

Indeed. I've not had luck engaging with the lmdb-rs project recently. I have several PRs pending, the first two of which are now two months old. And you've received no response to your issue danburkert/lmdb-rs#33. So I think we're going to need to fork the project and maintain our own fork, at least for the time being, in order to make this and other changes to it.

from rkv.

Agreed, let's fork it for now. Its code looks pretty neat and well-organized, should be easy for us to maintain and develop.

from rkv.

Agreed, let's fork it for now. Its code looks pretty neat and well-organized, should be easy for us to maintain and develop.

Ok, I've forked it to https://github.com/mozilla/lmdb-rs/ and added you as a collaborator!

from rkv.

Close it via #61

from rkv.