Giter VIP home page Giter VIP logo

Comments (7)

AJIOB avatar AJIOB commented on June 10, 2024 1

Although the URL is technically valid, incorporating the password directly within the endpoint is risky, as the endpoint is not excluded from Debug output. This oversight could potentially expose the password in logs or traces, leading to a security vulnerability.

Make sense. Let's provide additional variables for the username & password for the Redis. Will it be OK?

from sccache.

AJIOB avatar AJIOB commented on June 10, 2024

P.S. Username & password may be passed as a part of the SCCACHE_WEBDAV_ENDPOINT too (optionally), because it is still a valid URL.
P.P.S. The Redis backend connection parameters are passed in the same manner that I suggest to WebDAV.

from sccache.

Xuanwo avatar Xuanwo commented on June 10, 2024

The prefix is based on input endpoint.

Some webdav services could expose webdav at /v1/webdav, so it might be confusing to extract them as path.

Username & password may be passed as a part of the SCCACHE_WEBDAV_ENDPOINT too (optionally), because it is still a valid URL.

Although the URL is technically valid, incorporating the password directly within the endpoint is risky, as the endpoint is not excluded from Debug output. This oversight could potentially expose the password in logs or traces, leading to a security vulnerability.

from sccache.

AJIOB avatar AJIOB commented on June 10, 2024

Some webdav services could expose webdav at /v1/webdav, so it might be confusing to extract them as path.

As I can see in Artifactory docs - just used as an example - I should use artifactory/repo-path as a part of the SCCACHE_WEBDAV_ENDPOINT or as a SCCACHE_WEBDAV_KEY_PREFIX value now?

from sccache.

Xuanwo avatar Xuanwo commented on June 10, 2024

As I can see in Artifactory docs - just used as an example - I should use artifactory/repo-path as a part of the SCCACHE_WEBDAV_ENDPOINT or as a SCCACHE_WEBDAV_KEY_PREFIX value now?

From my perspective, I believe the endpoint should be http://host:port/artifactory/repo-path, a valid WebDAV service that points to the top-level directory accessible by users. With this endpoint as a basis, we can determine the key prefix and more.

Let's provide additional variables for the username & password for the Redis. Will it be OK?

LGTM. We should encourage users to use the username and password provided by the config instead of directly in the URL.

from sccache.

AJIOB avatar AJIOB commented on June 10, 2024

LGTM. We should encourage users to use the username and password provided by the config instead of directly in the URL.

You prefer to drop the current format support for the new one or just support both or them?

from sccache.

Xuanwo avatar Xuanwo commented on June 10, 2024

You prefer to drop the current format support for the new one or just support both or them?

Dropping current format might lead to a breaking change which is not good. I prefer to support both by including username and password in the config. We can also add a note in our documentation, advising new users that using password is recommended.

from sccache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.