Supporting event tooltips in the markup-view about valence HOT 3 CLOSED

After a second look, except if we change the way the eventlistener popup works, we can't achieve the same here.
Indeed, NodeActors send a hasEventListeners boolean flag as part of their form. form() is a sync method, so when it runs, we cannot call DOM.getEventListenersForNode to check whether the node has event listeners, cause this call is async.

So either we change the event listener popup mechanism by making the markup-view call a new hasEventListeners method on the actor when it imports it, or we do that call in the walker, when referencing a new node.

from valence.

@MikeRatcliffe what do you think we could do here?

from valence.

Well, we plan on moving the event checks into it's own actor as the code is duplicated between the debugger and inspector at the moment.

hasEventListeners has very little cost so we can do that wherever but getEventListeners needs the debugger to be initialized so that is very costly.

We could have hasEventListeners in the walker, that would make sense but I am not sure about the performance hit.

Because we need to move the events stuff into it's own actor maybe a new hasEventListeners method on that actor makes the most sense.

from valence.