Hide pretty-printing & blackboxing buttons (or make them work) about valence HOT 8 CLOSED

There was a suggestion that the UI could disable the buttons if a blackbox/pretty-print request returned with a "not implemented" message, but that may be more trouble than it's worth. I think I actually will be able to get blackboxing working. For pretty-printing, as long we show an error somewhere I think that's ok. Now sure how to tell the UI to show an error from the backend though.

Worst case pretty-printing just won't do anything, I guess.

from valence.

How are you planning to do this?

from valence.

Can you send custom traits that the frontend could look for and hide the buttons there based on those values? I think that is what they are intended for (as in, to avoid having to wait for an error to happen on a request before realizing it won't work).

Alternatively you could dig into the DOM of the current toolbox from the extension and hide the buttons.

from valence.

Usually we add traits that assert something new is on the server and nonexistence means you are talking to an older server (like editOuterHTML), but I don't see why you couldn't add a negated trait (like noPrettyPrinting).

Realistically, waiting for the debugger panel to open then digging into the DOM and looking for these buttons by ID and setting the hidden attribute is kind of gross, but I think it'd work fine.

from valence.

Yeah, I'll look into adding a trait. That would definitely be the easiest. I think I can get blackboxing working. Will do this today.

from valence.

I attached a patch to this bug to add the traits: https://bugzilla.mozilla.org/show_bug.cgi?id=1093349

Not sure who's the best reviewer, I'll talk with Panos tomorrow and see if he can (maybe Victor would better...)

from valence.

Bug 1093349 is resolved fixed, and the buttons are successfully hidden, but the "Auto Prettify Minified Sources" and "Automatically Black Box Minified Sources" options are still present but non-functional in the Debugger's settings menu. Should we hide those as well?

from valence.

That's a good point @callahad. I think it's a pretty easy fix, one just needs to look at the changes @jlongster made in https://hg.mozilla.org/integration/fx-team/rev/85786620f4af

from valence.