Comments (3)
Makes sense to combine them into one. Probably result from implementing this in phases.
I would go with the tuples. I would only do Unknown(String, u64)
as I assume in case of unknown you first want to look at the type.
from webrtc-sdp.
One thing I find is that if the bandwidth comes first, then I can always grab the first element to get the bandwidth value, regardless of variant.
from webrtc-sdp.
But the bandwidth numbers is completely meaningless without the type, because you don't even know if it's in bits, bytes, kilo-bytes or whatever other unit.
from webrtc-sdp.
Related Issues (20)
- Add a new Error to specifically reject a=crypto lines
- Consider broader use - generating SDP not just parsing, not just webrtc HOT 3
- ice-lite SDP parsing error on hangouts and meet HOT 3
- Sessions with Multiple Media yield embedded, redundant \r\n HOT 1
- SDP parsing error HOT 3
- Improve the error message for missing attribute parameter values to include the name of the parameter
- Set connection force method on SdpMedia HOT 1
- Correct new lints present on rust stable
- profile-level-id parsed as hex but serialized as decimal HOT 4
- Adding check_parse_and_serialize() to unit_tests.rs
- Travis CI free usage ends Dec 3; mozilla repos should switch to other CI platforms HOT 2
- Add code coverage checks in CircleCI builds
- Accept the additional dynamic format number range of 35 to 63 HOT 1
- SdpAttributeFmtpParameters with unknown tokens does not include delimiter when writing to string HOT 2
- parse_media not covering valid fmt's HOT 3
- Unknown rtcpfb feedback type: "rrtr“ ? HOT 3
- Add SDP example and unit test for parsing a connection lines with an FQDN
- Crates.io release HOT 2
- Inappropriate validation of direction consistency between simulcast attr and direction attr
- Missing support for framerate attribute
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webrtc-sdp.