Use object for optional arguments about express-oas-generator HOT 7 CLOSED

I strongly agree. The init function gets (is) messy and if we add more options in the future, it will get cluttered even more.

While we're at it, I think that the second parameter aPredefinedSpec should also be optional, since you're allowed to pass in an empty object to it, so why not make it optional too?

from express-oas-generator.

@mpashkovskiy @kiprasmel Would you agree to close this one in favor of #65 ?

from express-oas-generator.

@mpashkovskiy @kiprasmel Would you agree to close this one in favor of #65 ?

Sorry, not sure that understand how switching to single object parameter in init/handleResponses related to deprectaion of init. Could you please clarify?

handleResponses already has an options object parameter. This is specific for init and we're gonna deprecate it 😄

from express-oas-generator.

That is a good idea. But it will break existing integration. I will create v2.0.0 of the module and PR is warmly welcomed!

from express-oas-generator.

I'd like to finish with #39 before this.
I can make a PR afterwards.

from express-oas-generator.

@maxiejbe

Would you agree to close this one in favor of #65 ?

Absolutely.

from express-oas-generator.

@mpashkovskiy @kiprasmel Would you agree to close this one in favor of #65 ?

Sorry, not sure that understand how switching to single object parameter in init/handleResponses related to deprectaion of init. Could you please clarify?

from express-oas-generator.