Giter VIP home page Giter VIP logo

Comments (3)

mperrin avatar mperrin commented on June 16, 2024

This would be more straightforward to implement now with the refactored and unified matrix DFT code. But for typical poppy and webbpsf use cases it wouldn't be a major performance gain since it's not typical to do the same transform repeatedly. Gerchberg-Saxton is a difference case of course.

So I suggest we're not going to prioritize this as part of the main development efforts - but would certainly welcome a patch from Anand or any other user if they wants to work on it.

from poppy.

josePhoenix avatar josePhoenix commented on June 16, 2024

From looking at (and ultimately removing) the Zernike cache, the relevant gotchas would be: returning copies of the array in the cache rather than references / marking the cached arrays as read only (to prevent accidental in-place modification), and ensuring ALL the relevant parameters are used in the cache key (to prevent the issue of changing a parameter and getting the same array back because the cache doesn't know about that parameter).

from poppy.

mperrin avatar mperrin commented on June 16, 2024

Stale issue with no action in the last 2 years, and no compelling need to prioritize it. I'm going to mark this wontfix & close.

from poppy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.