Comments (3)
This would be more straightforward to implement now with the refactored and unified matrix DFT code. But for typical poppy and webbpsf use cases it wouldn't be a major performance gain since it's not typical to do the same transform repeatedly. Gerchberg-Saxton is a difference case of course.
So I suggest we're not going to prioritize this as part of the main development efforts - but would certainly welcome a patch from Anand or any other user if they wants to work on it.
from poppy.
From looking at (and ultimately removing) the Zernike cache, the relevant gotchas would be: returning copies of the array in the cache rather than references / marking the cached arrays as read only (to prevent accidental in-place modification), and ensuring ALL the relevant parameters are used in the cache key (to prevent the issue of changing a parameter and getting the same array back because the cache doesn't know about that parameter).
from poppy.
Stale issue with no action in the last 2 years, and no compelling need to prioritize it. I'm going to mark this wontfix & close.
from poppy.
Related Issues (20)
- need to update minimum version of astropy in setup.py HOT 1
- python3 Integer division in poppy/utils.py HOT 2
- calcPSF halts in certain specific circumstances. HOT 5
- zernike.arbitrary_basis still sometimes clips the edges of apertures HOT 1
- Fresnel propagation detector and setting pixel pitch HOT 1
- poppy travis builds failing silently HOT 1
- OpticalSystem.input_wavefront default sampling should look to OpticalSystem attributes first
- API inconsistency in specifying shifts between FITS and Analytic optics
- test function `test_fresnel_FITS_Optical_element` misses the point
- Bug in QuadraticPhase? HOT 14
- Implement ThermalBloomingWFE HOT 1
- loading FFTW wisdom from disk is unreliable?
- re-importing modules breaks fresnel propagation HOT 3
- Clone / copy repo to https://github.com/spacetelescope/poppy HOT 6
- Adding user-defined Fresnel wavefront error HOT 3
- Remove all Python 2.x items HOT 2
- Phase and ampliude modulation HOT 2
- Missing dependence on pysynphot HOT 2
- Support for intermediate planes? HOT 1
- poppy.display_profiles() Output Plot Inquiry
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from poppy.