poppy.zernike functions return references to cached arrays instead of copies about poppy HOT 3 CLOSED

Oop, another pitfall: mask_outside / outside kwargs aren't part of the tuple stored in _ZCACHE.

from poppy.

I wasn't previously aware of the writeable flag option for numpy arrays. Nice tip.

The above all sounds like a good plan to me, yes. In terms of the LRU cache, I see that Python 3.3 introduced a built-in LRU cache decorator (see https://docs.python.org/3/library/functools.html ), and there exists a back port of this to 2.6+ (http://code.activestate.com/recipes/578078-py26-and-py30-backport-of-python-33s-lru-cache/) . So one efficient route might be to bundle the back port for now, in the expectation of eventually standardizing on the Python 3.3 option someday. Unless you already have another cache implementation in mind?

from poppy.

Resolved by removing _ZCACHE entirely. If we want to add caching behavior back in later, we should open an issue for that.

from poppy.