Giter VIP home page Giter VIP logo

Comments (3)

assembledadam avatar assembledadam commented on June 2, 2024

Oh, and the Facebook Embed provider also appears to be cutting off the embed (although from the code it looks like this is based on the response height, so not sure there).

from embera.

mpratt avatar mpratt commented on June 2, 2024

Hi @assembledadam ! Thanks for the report!

You are right, It was a bug when a response contained a multidimentional array. I Fixed it and will be tagging a new release soon.

The problem you are experiencing with the facebook embed height is known. The problem is that the facebook html response contains javascript that could cause problems if you are already using facebooks javascript sdk or if you do multiple facebook embeds on the same page. So the best solution I found was to create and return an iframe, but the problem is that facebook normally doesn't return the height of the embed, so I had to add a minimum height of 650px, which in some cases isnt enough.

Every iframe has a distinct id so you can change the height via css. Every iframe has also a class that you can use to also change the height via css.

On the other hand, for the facebook provider, you can try and use the {raw.html} code (or $response['raw']['html'];) to get the original facebook response and see if it works better for you.

from embera.

assembledadam avatar assembledadam commented on June 2, 2024

Great - thanks for the quick fix & info regarding the known issue/possible workaround !

from embera.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.