Comments (3)
Oh, and the Facebook Embed provider also appears to be cutting off the embed (although from the code it looks like this is based on the response height, so not sure there).
from embera.
Hi @assembledadam ! Thanks for the report!
You are right, It was a bug when a response contained a multidimentional array. I Fixed it and will be tagging a new release soon.
The problem you are experiencing with the facebook embed height is known. The problem is that the facebook html response contains javascript that could cause problems if you are already using facebooks javascript sdk or if you do multiple facebook embeds on the same page. So the best solution I found was to create and return an iframe, but the problem is that facebook normally doesn't return the height of the embed, so I had to add a minimum height of 650px, which in some cases isnt enough.
Every iframe has a distinct id so you can change the height via css. Every iframe has also a class that you can use to also change the height via css.
On the other hand, for the facebook provider, you can try and use the {raw.html}
code (or $response['raw']['html'];
) to get the original facebook response and see if it works better for you.
from embera.
Great - thanks for the quick fix & info regarding the known issue/possible workaround !
from embera.
Related Issues (20)
- iFrame `frameborder` attribute is deprecated in HTLM5 HOT 1
- Add an option for iframe lazyloading HOT 1
- Spotify artist link not working
- Allow hidden vi HOT 1
- Silk defunct HOT 1
- Playbuzz implementation is incomplete HOT 1
- youtube rel=0 ? HOT 1
- How about dropping support php version prior to 7.2? HOT 3
- Allowing CKEditor5 code HOT 3
- Argument 2 passed to Embera\Http\OembedClient::__construct() must be an instance of Embera\Http\HttpClient, instance of Embera\Http\HttpClientCache given HOT 3
- Added Wordwall provider HOT 3
- Custom Provider Parameters HOT 6
- Broken/Unsupported Providers HOT 3
- Get video_id from Youtube URL HOT 3
- Facebook is problematic HOT 4
- Instagram oEmbed is deprecated HOT 1
- Support custom request headers HOT 2
- Vimeo private video links HOT 1
- Imgur not embedded? HOT 1
- Twitter embeds don't work on production HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from embera.