Git endpoint not working about meteor-bower HOT 4 CLOSED

It's failing here

https://github.com/mquandalle/meteor-bower/blob/master/plugin/handler.js#L59

when calling the bower npm package's install method. According to their docs, sending a git URL is fine (http://bower.io/docs/api/#install), so I'm guessing the problem is with our parsing of bower.json.

PR welcome

from meteor-bower.

Um, so, there's a lot of git repos flying around with bower.json's that aren't apparently in the bower package index for some reason or another. A lot.

The following works with the bower command in my bower.json:

"dependencies": {
    "Medium.js": "git://github.com/jakiestfu/Medium.js.git",
    "impress-js": "git://github.com/bartaz/impress.js.git"
  },

It's also possible to use the https:// instead of git:// protocol.

Regardless, neither work with this package.

My error is:

/Users/hunter/.meteor/packages/meteor-tool/.1.0.38.1ktyovf++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/dev_bundle/lib/node_modules/fibers/future.js:326:15:
   Failed to execute "git ls-remote --tags --heads git://github.com/bulkan/Medium.js.git", exit code of #128 (compiling
   bower.json)
   at Object.Future.wait
   (/Users/hunter/.meteor/packages/meteor-tool/.1.0.38.1ktyovf++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/dev_bundle/lib/node_modules/fibers/future.js:326:15)
   at Object.install (packages/meteor/helpers.js:116:1)
   at bowerHandler (packages/bower/plugin/handler.js:59:1)
   at Package (packages/bower/plugin/handler.js:181:1)

It's possible it's related to the fact that this is trying to use the package index, when I'm actually specifying a git link, because what's in the index is broken.

from meteor-bower.

This is the function that generates installList:

  var installList = _.map(bowerTree, function (definition, name) {
    if (_.isString(definition))
      definition = { version: definition };

    if (_.isEmpty(definition.version))
      compileStep.error({
        message: "You must provide a version number for package " + name
      });

    if (_.has(definition, "source"))
      name += "=" + definition.source;

    return name + "#" + definition.version;
  });

The end result is something like this:

[
  "Medium.js#git://github.com/jakiestfu/Medium.js.git",
  "impress-js#git://github.com/bartaz/impress.js.git"
]

Whereas it should look like this:

[
  "git://github.com/jakiestfu/Medium.js.git",
  "git://github.com/bartaz/impress.js.git"
]

from meteor-bower.

Update has been pushed to atmosphere, please let me know whether it works, thanks!

from meteor-bower.