Giter VIP home page Giter VIP logo

Comments (4)

nicolaiw avatar nicolaiw commented on July 17, 2024 1

As we implement it by hand I suggest we could close this Issue.

from zigbeenet.

eiaro avatar eiaro commented on July 17, 2024

Please use same names in types as the API has. This makes it easier to follow.

from zigbeenet.

Mr-Markus avatar Mr-Markus commented on July 17, 2024

I tought about the whole concept of commands and now i am at the point I would say that the current solution is not very well. Also T4 templates. Instead of using JSON definitions we should use own classes for each request and response. And these classes should be inherited from an base class (e.g. SerialPacket)

So I' thinking about removing ZpiObject, ZpiSREQ, ZpiMeta and the json files.

The sending and reading methods are already a good solution and should be further used

@nicolaiw
What do you think?

from zigbeenet.

Mr-Markus avatar Mr-Markus commented on July 17, 2024

I created a new branch rework with commit 8c31c81

I removed all ZpiObject classes and created Packet Directory in which classes with correct names are contained. This commit was the first step and just nine classes are implemented to start the Hardware and starts PermitJoin. On my machine the Example it is running:

[07:44:07 DBG] Opening interface...
[07:44:08 DBG] Interface opened...
[07:44:08 INF] Application started
[07:44:08 DBG] Transmitted: SubSystem: SAPI, Type: SREQ, Length: 0, Cmd: 0
[07:44:10 DBG] Paket read: SubSystem: SAPI, Type: SRSP, Length: 0, Cmd: ZB_START_REQUEST_RSP
[07:44:10 DBG] Paket read: SubSystem: ZDO, Type: AREQ, Length: 1, Cmd: ZDO_STATE_CHANGE_IND
[07:44:10 INF] State changed: Started_as_ZigBee_Coordinator
[07:44:10 DBG] Transmitted: SubSystem: ZDO, Type: SREQ, Length: 0, Cmd: 0
[07:44:10 DBG] Paket read: SubSystem: ZDO, Type: SRSP, Length: 1, Cmd: ZDO_MGMT_PERMIT_JOIN_REQ_SRSP
[07:44:10 DBG] Paket read: SubSystem: ZDO, Type: AREQ, Length: 3, Cmd: ZDO_MGMT_PERMIT_JOIN_RSP

Code is not yet perfect, but i need to have some sleep. More will come soon

from zigbeenet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.