mrdoob / texgen.js Goto Github PK

I was looking for a texture generation library, and have little experience in the area. The README didn't help :)

At over 1,100 stars for the repo, I'm probably missing something obvious.

Do you think using 0-255 values for the tint parameters would be better? I've found myself always using the 256 rgb value / 255. It could either replace 0-1 entirely, or it could work without changing the current functionality by assuming any input above 1 is a 256 rgb value, although this would make 1 & 255 equivalent inputs. I am willing to code this change.

Every TG.Program needs the same two functions getParamsand setParamValue.

getParams: function () {
    return params;
},
setParamValue: function ( id, value ) {
    params[ id ] = value;
},

Could be nice to be implemented just in TG.Program, not on every subclass.

In project description (Github) the URL http://texgenjs.org/ redirects to http://texgenjs.org/%20%20

Try to remove spaces at the end of URL.

I think it would be better if TG.Number was renamed to TG.Constant.
In my opinion, it makes a bit more sense in the context of generating values and gives a better idea of what it does and what it is used for.

The build file isn't updated !

TG.RadialGradient doesnt exist in the min version

It'd be nice to be able to blur a texture (for getting a glowing effect).

The main site doesn't seem to be a demo, but just displays a PNG of some samples. Can't you add a live example on that page, to demonstrate what it doesn? You might also want to explain that the rendered result is a canvas element (which I'm assuming because of the method name in your code example). Thanks!