Giter VIP home page Giter VIP logo

Comments (6)

mrklein avatar mrklein commented on June 28, 2024 1

Guess, v1812 is not relevant any more?

from openfoam-os-x.

mrklein avatar mrklein commented on June 28, 2024

Yes, I can. But I do not see a reason why.

from openfoam-os-x.

friedenhe avatar friedenhe commented on June 28, 2024

Great! We developed a discrete adjoint capability for design optimization with OpenFOAM (check here). Our code is based on OpenFOAM-v1812 and it is hard for us to upgrade to a newer OF version. We tried to follow the wiki and managed to compile OF on MacOS. However, it seems that the oldest supported version is v1912, so we wonder if you can add the v1812 patch. Thanks again!

from openfoam-os-x.

mrklein avatar mrklein commented on June 28, 2024

Well, I see the reason why you need it, I still do not see the reason why should I create it.

from openfoam-os-x.

olesenm avatar olesenm commented on June 28, 2024

Great! We developed a discrete adjoint capability for design optimization with OpenFOAM (check here). Our code is based on OpenFOAM-v1812 and it is hard for us to upgrade to a newer OF version. We tried to follow the wiki and managed to compile OF on MacOS. However, it seems that the oldest supported version is v1912, so we wonder if you can add the v1812 patch. Thanks again!

@friedenhe - instead of requesting patches for older versions of OpenFOAM, you would do better to see what is actually needed to update your code to a newer version of OpenFOAM. In addition to the upgrade guides, you can probably also refer to corresponding parts of the OpenFOAM source code to see which changes are needed.

If we compare the upstream checkTools.C and your checkTools.C, there is an obvious amount of overlap. You should easily be able to apply an update there, but preferably not remove the copyright and license information this time!!

from openfoam-os-x.

friedenhe avatar friedenhe commented on June 28, 2024

@olesenm, thanks very much for the suggestions! We will add the copyright and license info back. Yes, we are trying to upgrade our code with higher versions of OpenFOAM. The main DAFoam code should be straightforward to upgrade, the tricky part is that we used an automatic differentiation tool to overload all data types in OpenFOAM and differentiate its source code on this OpenFOAM-v1812-AD repo. Upgrading that repo for a higher version of OpenFOAM may need some work. You left a message for us and suggest we rebase our code to upstream. We've just started doing that and may need your help. I left a message for you there. Thanks!

from openfoam-os-x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.