Giter VIP home page Giter VIP logo

Comments (4)

mmellado avatar mmellado commented on July 28, 2024

Playing around with the declaration file locally, I figured there is a couple of issues with the index.d.ts file being exported in the library.

First, the d.ts file is not declaring a module. This is not a big deal, but it would go along with convention from what I've seen. The second issue is that in index.js, the Client is exported with module.exports = Client, which generates a "defaul export", but the d.ts file is not exporting the class as default.

I could submit a PR to fix this, but I wonder if this needs to be done on this repo or on. the replit/database fork?

from repl.it-db.

cursorweb avatar cursorweb commented on July 28, 2024

ideally you put this in the fork but they don't maintain that for some reason

from repl.it-db.

horaciovelvetine avatar horaciovelvetine commented on July 28, 2024

Can I show up here to complain about the lack maintenance also.... thnx for the great work @mrlapizgithub !!!

from repl.it-db.

cursorweb avatar cursorweb commented on July 28, 2024

haha np :)

from repl.it-db.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.