Queue processing should be prevented until login is complete about node-ftp HOT 2 OPEN

I'm all for pull requests to improve things :-)

from node-ftp.

I thought you might say that. ;-)

I almost got to that stage while debugging yesterday, but I'm not sure I quite understand the implications of making changes of this scope.

I'm actually not quite sure why _reset is called when a login fails. One approach might be to implement an internal flag for the ready state, similar to the connected flag. I think this would then allow the parser response listener to avoid calling _send() to process items in the queue if the connection isn't ready.

The re-entry callback would also need to be modified so the socket doesn't get ended for error responses to USER or PASS commands. It would then be up to the user to detect failed logins and re-attempt connection. (Maybe connect should accept a callback to explicitly call with an error object if a connection or login fails, that way it's easier to know that a re-connection is required rather than having to process an error event to find out if it was a connection or login error? Though this doesn't help for a dropped connection as per my scenario above.)

Another idea might be to have the _reset() function call any callbacks on queued items with an error before destroying the queue.

from node-ftp.