Add atomic transfer ability to fastPut? about ssh2-streams HOT 5 CLOSED

I think I'd prefer to leave that to userland to implement something like that. From my experience, convenience features like these typically end up being highly opinionated and I try to keep the module's focus on getting the core/less opinionated things right.

from ssh2-streams.

Ok. thanks.

from ssh2-streams.

@mscdex I looked a bit harder at this and my preference is to modify the behavior of fastPut that way I only need to implement the rename in one place (as putDirectory, etc all use it underneath the hood). Unfortunately, I didn't find a good mechanism to intercept the behavior, so I did it this way via a monkey patch: https://github.com/garygrossgarten/github-action-scp/blob/09a05dd06e8768d1327f701ef081f6f063834c3b/src/index.ts#L25

Generally speaking it seems that monkey patching is discouraged in Javascript, but there doesn't seem to be a hooking mechanism to insert the rename in there. Did I miss something? Would you be willing to insert a hook for this sort of thing, or do you think the monkey patching is fine.

Thanks! We've found this library (indirectly) to be really useful for automating our builds, I'm glad it exists. :)

from ssh2-streams.

There is no hooking mechanism. A better alternative would be to just make it a new function (not on the prototype of course) instead of overwriting the existing fastPut() and have your application use that instead 🤷‍♂️

from ssh2-streams.

Well, but then I'd have to copy and change the massive bit of code that involved putting a directory, in addition to the file putting code....

Oh, I see! 🤦 I had thought putDirectory was in this library, but it's in node-ssh. I'll make a different issue there.

from ssh2-streams.