Giter VIP home page Giter VIP logo

Comments (3)

mschwager avatar mschwager commented on August 23, 2024

Thanks again for reporting! Yes! We should definitely continue searching even if one query times out. I'll commit a fix!

from fierce.

timmc avatar timmc commented on August 23, 2024

Looks good!

Might be worth moving the whole subdomain loop body to a function and wrapping it in a more general exception handler -- I think besides the EmptyLabel and Timeout exceptions, I might have seen another one. I'll report it if I see it, but a more general solution (skip ones in error? die, but allow restarting from next subdomain position?) might be worth considering.

from fierce.

mschwager avatar mschwager commented on August 23, 2024

Yeah, I need to find a way to handle exceptions better. It feels like I'm playing whack-a-mole with all the possible network/DNS errors. Perhaps the best way forward would be catching exceptions generally, logging them, and moving on. Although, some exceptions may be more dire than others. Hmm, probably requires some further investigation...

from fierce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.