Comments (5)
Hi @mszostok 😄
Thanks for the explanation! Now I better understood the use of the not_owned_checker_skip_patterns
.
Your project fits very well in our scenario! We'll take a look at your feedback on PR 🎉
from codeowners-validator.
Hi, I decided to merge the PR as it was in general a 100% valid case. I extracted the generalization logic to a separate issue 👍 The user-facing behavior will stay the same, so by default the @ghost user will be deleted :)
Thanks for your interest in this project and your active support!
I will try to do a release with this enhancement this Sunday :)
from codeowners-validator.
PR opened #53
from codeowners-validator.
Thanks for reporting that problem.
Just a little context:
The not_owned_checker_skip_patterns
it is a config for Not Owned File Checker
and allows you to ignore patterns. For example, you can specify *
and as a result, the *
pattern from the CODEOWNERS file will be ignored and files owned by this pattern will be reported as unowned unless a later specific pattern will match that path. It's useful because often we have default owners entry at the begging of the CODOEWNERS files, so with *
always all files have an owner. But sometimes you want to ensure that the list maintained by the default codeowners is empty or short and here not_owned_checker_skip_patterns
option is helpful.
Regarding your problem, first, we need to take a look at the CODEOWNERS file:
* @global-owner1 @global-owner2
so the syntax is pattern owner1..owner2
. In your case you want to skip/whitelist owner in case of Valid Owner Checker
.
Unfortunately, it's not possible with the current version but what we can do is to add ignore_owners
which takes a list of owners e.g. users, teams etc. that should be ignored by Valid Owner Checker
.
Thanks also for the contribution, I will take a look on that PR :)
from codeowners-validator.
I have a scenario in my CODEOWNERS file, which I define as the owner of a path is @ghost because it's a trick to avoid getting review requests. The problem is that when I run the checker through GH actions, it returns this error:
[err] line 13: User "@ghost" is not a member of the organization
(because in fact, this "user" does not exist)
@LetticiaNicoli If the "ghost" user does not exist, it will invalidate the entire CODEOWNERS file. From the documenation:
If any line in your CODEOWNERS file contains invalid syntax, the file will not be detected and will not be used to request reviews. Invalid syntax includes inline comments and user or team names that do not exist on GitHub.
from codeowners-validator.
Related Issues (20)
- Comments in CODEOWNERS
- notowned with an empty codeowners file HOT 1
- Validate GitHub token scopes when `owners` check is enabled
- Add native support for pre-commit hook HOT 6
- Valid Owner Checker should report if the owner doesn't have Write access HOT 1
- App authentication doesn't work with provided action HOT 10
- /folder/* wildcard pattern is assumed to be nested by the action "Not Owned" check, which it isnt HOT 1
- CODEOWNERS file existence check HOT 1
- Unnecessary failure of test of GitHub token
- Killed: 9 HOT 8
- Error and mismatched URLs when using github app credentials via github enterprise
- Add support for specifically excluding code owners on files and subfolders HOT 1
- Recommended App permissions don't appear to be sufficient
- codeowners-validator install.sh crit-platform error for linux/arm64
- Print a list of all files and their owners HOT 1
- Owner child team is not supported by codeowners-validator
- Executing File Exist Checker Not support glob
- Feature request: fail for deleted files that are explicitly owned in CODEOWNERS HOT 4
- Support Gitea codeowners
- Runtime Error: segmentation fault codeowners-validator HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codeowners-validator.