Comments (2)
cktaylor
commented on June 4, 2024
1
It is mentioned in the linked thread - but to call it out explicitly, another situation to consider (that may be out of scope of this issue though) is that it is equally problematic if the CODEOWNERS rule specifies a single team and that team has a single user.
Given that codeowners-validator already has logic to talk to Github for team/org metadata - if it is possible to get team size from that, and if the proposed multiowners flag/mode is being added - I just wanted to point out this broader functionality would also be useful.
from codeowners-validator.
micimize
commented on June 4, 2024
@cktaylor this is true, but a much harder thing to put guard rails on, as team size can change externally and cause issues
from codeowners-validator.
Related Issues (20)
- notowned with an empty codeowners file HOT 1
- Validate GitHub token scopes when `owners` check is enabled
- Add native support for pre-commit hook HOT 6
- Valid Owner Checker should report if the owner doesn't have Write access HOT 1
- App authentication doesn't work with provided action HOT 10
- /folder/* wildcard pattern is assumed to be nested by the action "Not Owned" check, which it isnt HOT 1
- CODEOWNERS file existence check HOT 1
- Unnecessary failure of test of GitHub token
- Killed: 9 HOT 8
- Error and mismatched URLs when using github app credentials via github enterprise
- Add support for specifically excluding code owners on files and subfolders HOT 1
- Recommended App permissions don't appear to be sufficient
- codeowners-validator install.sh crit-platform error for linux/arm64
- Print a list of all files and their owners HOT 1
- Owner child team is not supported by codeowners-validator
- Executing File Exist Checker Not support glob
- Feature request: fail for deleted files that are explicitly owned in CODEOWNERS HOT 4
- Support Gitea codeowners
- Runtime Error: segmentation fault codeowners-validator HOT 2
- Support fine-grained PATs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codeowners-validator.