Address bar lacks contrast with built-in themes about materialfox HOT 22 CLOSED

I'm unable to reproduce the behaviour you see with the default theme. This is meant to replace the light theme; was the only way to do it and retain lightweight theme support. You should be seeing a light grey tab bar, not a black one.

The problem with the built-in light and dark themes is their colours just don't suit it very well when the address bar doesn't have a border. Because lightweight themes are essentially interchangeable between Firefox and Chrome now, I tried to stay with Chrome's behaviour.

from materialfox.

This is what it should look like, tested on a new profile with freshly cloned repo (macOS Mojave Light theme, b0aa0cd with Firefox 62.0.3's default theme). Would you mind testing on a new profile? Can do it through about:profiles. I'll test it with beta in the meantime.

from materialfox.

Firefox Beta (63.0b11) looks exactly the same for me.

from materialfox.

Still works the same for me. Also tested macOS dark mode, default and dark look identical there.

from materialfox.

Ok I can verify that this occurs when you have "Show scroll bars: Always" set in Preferences. I use -moz-overlay-scrollbars to check for macOS as per this article. It seems it isn't as robust as they think. I'll look for an alternative.

from materialfox.

I had it set on automatic FWIW, but changing it to "when scrolling" did not fix the issue for me.

from materialfox.

I'm guessing you don't have a touchpad? Try the latest commit. Haven't tested to make sure Windows isn't affected yet.

from materialfox.

I'm guessing you don't have a touchpad?

I do, but I'm not using it.

I forgot to say that it did not fix the issue for me on light and dark themes (since light theme is suggested on readme), the default theme works as intended when I change the scrollbar preference.

Same goes for 98f9acd and when I manually changed userChrome to fix that bug - still only works as intended on default theme, when hiding scrollbars by default.
Maybe you'll have to create another about:config preference for this?

from materialfox.

Sorry, it's on mac-selector branch, forgot to mention!

from materialfox.

Damn, that selector also works for Windows... I'll keep looking.

from materialfox.

Instructions have been updated to reflect that built in light and dark themes may clash with address bar. You can use MaterialFox Helper to force Chrome's dark or light theme. Not mentioned in readme because it is still experimental.

from materialfox.

Haven't tested the commit or extension yet, but the fact that you made an extension got me thinking: what if you don't force any titlebar color for the default theme at all?

That would especially emulate Linux behavior where Chromium has two default themes - light or system titlebar.

from materialfox.

I'll need to set up a VM to test this but ideally, it sounds like Linux should act more like Windows. If I can find a CSS selector which targets Linux I might be able to fix the behaviour.

from materialfox.

Today I had a chance to try this theme on Windows 7, and I saw that the toolbar was always black, even when trying some configurations with Helper (which successfully changed the titlebar though). Might've been related to the fact that the browser was in permanent no-history mode, but it seemed like Helper should've given an option nevertheless (as it detected private mode, but had an option for light theme).

Tried master, not mac-selector though, the device had Aero enabled.

from materialfox.

On another note, I can confirm that the mac-selector works on Mojave with or without static scrollbars.

from materialfox.

Set up a Ubuntu VM to test and fixed a few issues I noticed. I'd say it's close enough to Chrome to call it a day.

Still need to set up a Windows 7 VM to test, but one of my Ubuntu fixes may have resolved the toolbar issue in Windows 7, at least if it has anything to do with the tab bar (I'm being a bit optimistic).

from materialfox.

Tested on Manjaro (GNOME DE, like Ubuntu) and it looks very close, only big difference I see is that the tab titles are larger on Chromium, but I don't think that's worth changing 😁

from materialfox.

Thanks for testing. Yeah, I noticed that too but couldn't be bothered fixing. I might revisit it later.

from materialfox.

Fixed the issues on Windows 7 and added the tab and toolbarbutton colours from Chrome on Windows 7 so it should look almost identical to Chrome now.

If you're able to test on Windows 7 and confirm that it looks right, I'll close the issue.

from materialfox.

In Windows 7, Light theme, inactive tabs and the text are both black.

Edit: All is well if i use Material Helper, but I've found another small bug: search box is bigger than address bar.

from materialfox.

Resolved searchbar issues in 50723ab.

I'm looking into the Windows 7 issue.

from materialfox.

Closing this because the original issue has been resolved. No longer requires MaterialFox Helper - the theme will detect the default light/dark theme colours and force the related CSS vars to use the Material colours instead. Not quite working 100% for private browsing mode but I'll look into that one.

from materialfox.