Giter VIP home page Giter VIP logo

Comments (6)

muckSponge avatar muckSponge commented on July 4, 2024 1

Resolved in eb51d01. Decided not to disable overflow for now.

from materialfox.

muckSponge avatar muckSponge commented on July 4, 2024

The tabs actually aren't meant to overflow at all so this is possibly caused by a regression or I haven't been testing with enough tabs. I've reproduced the problem and will see if I can disable overflow entirely.

This appears to resolve the problem:

.tabbrowser-tab
{
  min-width: initial !important;
}
.tab-content
{
  overflow: hidden !important;
}

But I have to do further testing to ensure setting the min-width won't cause issues with tab drag/closing behaviour (which rely on some JS width-watching voodoo).

from materialfox.

Keith94 avatar Keith94 commented on July 4, 2024

It's better if tabs can overflow, in my opinion, because managing lots of tabs becomes difficult otherwise.

from materialfox.

muckSponge avatar muckSponge commented on July 4, 2024

I've had some pretty nasty issues with tab overflow due to the negative margin required on the tabs to support the curved tab style. It either causes premature overflow or makes it much harder to get out of overflow (you need to close more tabs than should be necessary). My solution was to disable overflow, which brings it inline with Chrome's behaviour. I can understand the desire to have tab overflow enabled when you use a lot of tabs but it may not be practical to achieve with this theme. I think hiding the scroll arrows did improve the situation but it's not ideal and was actually intended to help disable overflow altogether.

Happy to be proved otherwise, though!

from materialfox.

Keith94 avatar Keith94 commented on July 4, 2024

Hmm, it's hard to say. Prior to Firefox 57, they used a curved tabs design (+ overflow) without any "major" issues AFAIK. Could be some CSS tricks that make it work better.

Plus, over the years I've seen many complaints about Chrome's tab behavior (disappearing tab labels, etc.), but it's still your theme and your decision.

from materialfox.

Keith94 avatar Keith94 commented on July 4, 2024

Really good stuff!

from materialfox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.