Comments (6)
Resolved in eb51d01. Decided not to disable overflow for now.
from materialfox.
The tabs actually aren't meant to overflow at all so this is possibly caused by a regression or I haven't been testing with enough tabs. I've reproduced the problem and will see if I can disable overflow entirely.
This appears to resolve the problem:
.tabbrowser-tab
{
min-width: initial !important;
}
.tab-content
{
overflow: hidden !important;
}
But I have to do further testing to ensure setting the min-width
won't cause issues with tab drag/closing behaviour (which rely on some JS width-watching voodoo).
from materialfox.
It's better if tabs can overflow, in my opinion, because managing lots of tabs becomes difficult otherwise.
from materialfox.
I've had some pretty nasty issues with tab overflow due to the negative margin required on the tabs to support the curved tab style. It either causes premature overflow or makes it much harder to get out of overflow (you need to close more tabs than should be necessary). My solution was to disable overflow, which brings it inline with Chrome's behaviour. I can understand the desire to have tab overflow enabled when you use a lot of tabs but it may not be practical to achieve with this theme. I think hiding the scroll arrows did improve the situation but it's not ideal and was actually intended to help disable overflow altogether.
Happy to be proved otherwise, though!
from materialfox.
Hmm, it's hard to say. Prior to Firefox 57, they used a curved tabs design (+ overflow) without any "major" issues AFAIK. Could be some CSS tricks that make it work better.
Plus, over the years I've seen many complaints about Chrome's tab behavior (disappearing tab labels, etc.), but it's still your theme and your decision.
from materialfox.
Really good stuff!
from materialfox.
Related Issues (20)
- FF89: Tabs have unnecessary space above them when window is maximized HOT 6
- Speaker icon is on top of the favicon HOT 1
- favicon not visible in pinned tabs that show the playing/muted audio icon. HOT 1
- FF89: Tabs are "bugging" if I pin one and open many HOT 2
- search bar icons much smaller than intended HOT 3
- e
- Some Context Menu Items on Video Elements Have Pointer-Events Disabled
- Loading animation HOT 6
- FF94.0.2 (x64): Tabs have unnecessary space above them when window is maximized HOT 2
- [Feature/element] broken when [doing something] HOT 1
- FF 97: Tab heights HOT 1
- Kodeak~ HOT 2
- Window close/minimize buttons got a margin HOT 1
- [Feature/element] URL bar completely white HOT 24
- How can I make my search bar rounded/circled same as Material Fox does? HOT 3
- Images on home page HOT 1
- [Feature/element] broken when [doing something]
- Address bar totally broken on any dark theme HOT 4
- URL Address Text has incorrect vertical padding while focused after opening new tab. HOT 1
- Is this project dead? HOT 16
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from materialfox.