Giter VIP home page Giter VIP logo

Comments (4)

CelestialWorthy avatar CelestialWorthy commented on April 28, 2024

can you please explain more ?

from material-ui.

webdev51 avatar webdev51 commented on April 28, 2024

Sure, we have a MUI v4 theme where we have overrides setup which looks like this:

const theme = createTheme({
  overrides: {
    MuiButton: {
      contained: {
        backgroundColor: "grey",
      },
    },
  },
});

Now, if we have a button here which doesn't have a color defined f.e. <Button variant="contained">Grey</Button> , this button will have the backgroundColor from the overrides which is fine. But if a color="primary" is added to the same button, it will no longer have the backgroundColor from overrides but the actual primary color. This is the expected behaviour.
This behaviour is explained in this codesandbox which uses MUI v4.

Now, we're trying to upgrade to v5. In MUI v5, after following the docs and everything, I updated my config for the overrides as per the migration guides and overrides look like this:

const theme = createTheme({
  components: {
    MuiButton: {
      styleOverrides: {
        contained: {
          backgroundColor: "grey",
        },
      },
    },
  },
});

But after making this change and upgrading to v5, the behaviour is no longer the same as described above. Now, the overrides are being applied to both buttons regardless of color="primary" defined or not which is not desirable. This behaviour can be seen in this codesandbox with MUI v5.

from material-ui.

ZeeshanTamboli avatar ZeeshanTamboli commented on April 28, 2024

The answer was posted on StackOverflow: https://stackoverflow.com/a/78167813.

from material-ui.

github-actions avatar github-actions commented on April 28, 2024

👋 Thanks for using our open-source projects!

We use GitHub issues exclusively as a bug and feature requests tracker, however,
this issue appears to be a support request.

For support with Material UI please check out https://mui.com/material-ui/getting-started/support/. Thanks!

If you have a question on Stack Overflow, you are welcome to link to it here, it might help others.
If your issue is subsequently confirmed as a bug, and the report follows the issue template, it can be reopened.

from material-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.