Giter VIP home page Giter VIP logo

Comments (2)

brijeshb42 avatar brijeshb42 commented on June 1, 2024 1

This is a valid issue but to properly solve it, it seems like we might have to use a proper color string parser (that might be used in libraries like lightningcss) instead of relying on simple regex patterns, which we are doing right now. This will increase the bundle size when using @mui/system but will definitely help with Pigment CSS. I'll see if there is something that can be done for both.

Edit: This is in lightningcss that only handles color related features. Whole file might not be doing it but it's still a lot of cases to handle something that is not the core functionality of what we provide.

from material-ui.

danilo-leal avatar danilo-leal commented on June 1, 2024

Update here—it seems it could only be a syntax matter:

  • hsl(212 19 15) doesn't work
  • hsl(212 19% 15%) doesn't work
  • hsl(212, 19%, 15%) works!

Even though this solves my immediate problem for now, I think it might still be worth keeping the issue up, as all of these syntaxes are valid CSS (I'm just not 100% sure about the second option, though, with units and not commas—MDN doesn't mention it) and should be supported.

from material-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.