Giter VIP home page Giter VIP logo

Comments (30)

Krzmbrzl avatar Krzmbrzl commented on May 19, 2024 8

I can't really give a proper estimate. The answer is essentially "once I have the time to finish this", but as things stand right now, I can't tell you when that will be :/
Right now, working on the 1.5 release has priority. After that I'll probably turn to this.

from mumble-docker.

Krzmbrzl avatar Krzmbrzl commented on May 19, 2024 8

Alright folks, what kind of ARM images do you need? I have just added support for ARM64 via #37 which will become available as pre-built images for the new release series.
Any other architectures that are needed?

from mumble-docker.

Krzmbrzl avatar Krzmbrzl commented on May 19, 2024 4

I can't really give a proper estimate. The answer is essentially "once I have the time to finish this", but as things stand right now, I can't tell you when that will be

☝️

from mumble-docker.

timothysu avatar timothysu commented on May 19, 2024 2

Any updates on when an ARM version will be available? Or is there any chance the image that was released before the repo got taken down / restored could be also restored? For context I have an image I pulled from mumblevoip/mumble-server in March that has the ARM binaries...but that seems to be no longer available?

from mumble-docker.

Krzmbrzl avatar Krzmbrzl commented on May 19, 2024 2

We already have mumble-voip/mumble#5960 that will fix this issue. There are only a couple of small things left that need to be fixed before this can be merged.

However, I'm not particularly fond of spreading workarounds all over the place - aka: I'd prefer fixing up that PR than using a hand-crafted workaround in this repo 🤔

from mumble-docker.

CogentRedTester avatar CogentRedTester commented on May 19, 2024 2

armhf for older raspberry pis would be nice.

from mumble-docker.

Matthew-Beckett avatar Matthew-Beckett commented on May 19, 2024 1

Hi @Krzmbrzl,

I have successfully build, tested and deployed Mumble Server from your branch streamline-packetdatastream-imp.

As part of this I forked this repository and re-added building of ARM64 images, docker build caching, and the ability to build images in the Mumble Docker repository with code sources from a fork.

Would you like me to PR this work upstream?

Ideally if so, we should remove my development build and re-enable all the stable builds for all platforms. Change my work to push to GitHub Container Registry back to DockerHub, and probably remove the ability to build from foreign repository.

I added this to build from your fork, but I can see this being a potential supply chain vulnerability, if one of the maintainers GitHub account was compromised, it could be used to build malicious Mumble code from a fork and pushed to the official image repository.

from mumble-docker.

Krzmbrzl avatar Krzmbrzl commented on May 19, 2024 1

Hi @Matthew-Beckett,
Upstreaming this eventually would be great. However, we need to take care that we only enable ARM for builds that actually contain the necessary patch. After my branch gets merged that'll only be the master branch. Potentially we could backport it to the 1.4.x branch, but in either case none of the currently existing releases will be buildable on ARM as they don't contain the necessary patch.

So the ARM build should be enabled only conditionally. This should be easy enough though, as we specify the build targets and the corresponding target platforms explicitly anyway.

But first things first: The PR has to get merged. At the moment there are still some unresolved issues related to the new build flags.

from mumble-docker.

Matthew-Beckett avatar Matthew-Beckett commented on May 19, 2024 1

Hi @Matthew-Beckett,

Upstreaming this eventually would be great. However, we need to take care that we only enable ARM for builds that actually contain the necessary patch. After my branch gets merged that'll only be the master branch. Potentially we could backport it to the 1.4.x branch, but in either case none of the currently existing releases will be buildable on ARM as they don't contain the necessary patch.

So the ARM build should be enabled only conditionally. This should be easy enough though, as we specify the build targets and the corresponding target platforms explicitly anyway.

But first things first: The PR has to get merged. At the moment there are still some unresolved issues related to the new build flags.

Once merged if you want me to handle back-porting I can take a look.

from mumble-docker.

Krzmbrzl avatar Krzmbrzl commented on May 19, 2024 1

No the patch has not even been merged to master yet as there are unresolved build issues related to it and I have not yet found the time to look into this properly

from mumble-docker.

Krzmbrzl avatar Krzmbrzl commented on May 19, 2024 1

I can't really give a proper estimate. The answer is essentially "once I have the time to finish this", but as things stand right now, I can't tell you when that will be

☝️

☝️

Obviously, everyone is more than welcome to contribute the necessary fixes themselves. I certainly don't insist on doing everything myself 🤷
I currently simply don't have enough time to work on all issues that pop up around Mumble. I might have some more time to spend in August, but we'll have to see...

from mumble-docker.

theAkito avatar theAkito commented on May 19, 2024 1

Hi again. I understand and appreciate that you do this on your free time with no remuneration and I understand to an extent the importance of getting the newer version out the window, but when a subset of the user base is unable to use the software in question, I would think that would take precedence, especially when the fix was so far away (looking at the initial date of this issue). I wish there was at least an alternative for those of us wanting to run a server on docker ARM, like republishing an old image or something.

In such urgent cases, you would usually build your own, patched version, of the software in question.

If there's a workaround by using some Docker or OS internals, I can also help you with that.

It also depends on what "ARM" you all want. My Docker wrapper for murmur has just been awakened from its 3 year long sleep & I provide some ARM builds, that I think are common.

These are the platforms I build for. I probably could add more.

linux/arm/v7,linux/arm64/v8,linux/amd64

https://github.com/theAkito/docker-murmur

https://hub.docker.com/r/akito13/murmur

from mumble-docker.

Krzmbrzl avatar Krzmbrzl commented on May 19, 2024

Compilation with Ubuntu 20.04 isn't working on ARM (some lib are missing)

That's for ARM v7
On ARM64, the issue is mumble-voip/mumble#3845

from mumble-docker.

Krzmbrzl avatar Krzmbrzl commented on May 19, 2024

No updates yet, no.
Restoring the old image is also not possible afaik (and would seem to be legally questionable anyway).

from mumble-docker.

sirjeannot avatar sirjeannot commented on May 19, 2024

It looks like there won't be any for a while :(

from mumble-docker.

timothysu avatar timothysu commented on May 19, 2024

Did the patch make it into the 1.5.x release candidate? I tried building with the v1.5.517 tag and the tests still fail.

from mumble-docker.

timothysu avatar timothysu commented on May 19, 2024

Had a little time to look into this earlier today. I've been able to build per the discussion in mumble-voip/mumble#3845. As a result I have the v1.4.287 and v1.5.517 arm64 and amd64 builds available at https://hub.docker.com/r/timothysu/mumble-server/tags. I also still have the original v1.4.230 arm64 build published a long time ago repushed.

If you wish to build it yourself, it should work with --build-arg MUMBLE_CMAKE_ARGS="-DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_FLAGS_RELEASE=\"-fsigned-char\"".

The full command I used for the images pushed on my repo is docker buildx build --platform linux/amd64,linux/arm64 --build-arg MUMBLE_VERSION="v1.5.517" --build-arg MUMBLE_CMAKE_ARGS="-DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_FLAGS_RELEASE=\"-fsigned-char\"" -t timothysu/mumble-server:v1.5.517 . --push.

If this is legit could we get an official build via the above @Krzmbrzl?

from mumble-docker.

stryker7176 avatar stryker7176 commented on May 19, 2024

Any idea when this will be completed?

from mumble-docker.

Coxis avatar Coxis commented on May 19, 2024

We're coming up on the anniversary of this issue. Hopefully this can be resolved soon.

from mumble-docker.

Coxis avatar Coxis commented on May 19, 2024

Hi again. I understand and appreciate that you do this in your free time with no remuneration and I understand to an extent the importance of getting the newer version out the window, but when a subset of the user base is unable to use the software in question, I would think that would take precedence, especially when the fix was so far away (looking at the initial date of this issue). I wish there was at least an alternative for those of us wanting to run a server on docker ARM, like republishing an old image or something.

from mumble-docker.

Abbode avatar Abbode commented on May 19, 2024

For me ARM64 it is.
Thanks for listening to us.

from mumble-docker.

eTaurus avatar eTaurus commented on May 19, 2024

+1 for ARM64

from mumble-docker.

mmBesar avatar mmBesar commented on May 19, 2024

arm64 would be nice, thanks

from mumble-docker.

wikiwang1991 avatar wikiwang1991 commented on May 19, 2024

+1 for aarch64, thanks, looking forward to use official images

from mumble-docker.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.