Giter VIP home page Giter VIP logo

Comments (14)

rigonlucas avatar rigonlucas commented on May 27, 2024

I have a sugestion to fix this:

  1. In: vendor/munafio/chatify/src/ChatifyServiceProvider.php
  2. private function routesConfigurations change:
    'namespace' => 'Chatify\Http\Controllers', => 'namespace' => config('chatify.namespace', 'Chatify\Http\Controllers'),. to not break on composer update.
  3. In: config/chatify.php
    Add to config: 'namespace' => env('CHATIFY_NAMESPACE', 'App\Http\Controllers\vendor\Chatify'), By default this may bem Chatify\Http\Controllers in config and routesConfigurations

so as not to break applications of devs that are already using, it is necessary to leave the vendor standard

Congragulation @munafio for the project, it's a great work

I hope I contributed to the project.

from chatify.

munafio avatar munafio commented on May 27, 2024

@rigonlucas I wrote a notes to your PR .. please check that to merge :)
Thanks for your contribution.

from chatify.

rigonlucas avatar rigonlucas commented on May 27, 2024

@munafio here it is performing correctly. I suggest that you create a new branch for PR outside the master to test the change.
I realized that you have the master branch.
If you want to make this correction feel free to refuse my PR and apply the change.
Hug!

from chatify.

munafio avatar munafio commented on May 27, 2024

@rigonlucas I've suggested some changes to your PR to be merged and save your contribution.

from chatify.

rigonlucas avatar rigonlucas commented on May 27, 2024

Perfect, however you want. It was a pleasure to contribute! It's a beautiful project.

from chatify.

munafio avatar munafio commented on May 27, 2024

@rigonlucas Still waiting your changes :).
Thanks to you <3

from chatify.

rigonlucas avatar rigonlucas commented on May 27, 2024

@munafio I did the PR, but it is still open.
If you want that i change anything, please, coment here
#11

from chatify.

munafio avatar munafio commented on May 27, 2024

@rigonlucas I wrote a notes on your PR commits and still pending .. please check them and after your change, I'll merge your contribution.

from chatify.

khyvez avatar khyvez commented on May 27, 2024

3. 'namespace' => env('CHATIFY_NAMESPACE', 'App\Http\Controllers\vendor\Chatify'),

Hello brother, I tried your suggestion but I'm having error.
Target class [App\Http\Controllers\vendor\Chatify\MessagesController] does not exist.

from chatify.

rigonlucas avatar rigonlucas commented on May 27, 2024

Hi guy. Rum composer update and after republish the config command
You can rum the publish command for controllers

from chatify.

rigonlucas avatar rigonlucas commented on May 27, 2024

Rum**

from chatify.

rigonlucas avatar rigonlucas commented on May 27, 2024

@khyvez it's was been fixed manytimes ago.
Hug, and good work!

from chatify.

ahmadazizfauzan avatar ahmadazizfauzan commented on May 27, 2024
  1. 'namespace' => env('CHATIFY_NAMESPACE', 'App\Http\Controllers\vendor\Chatify'),

Hello brother, I tried your suggestion but I'm having error.
Target class [App\Http\Controllers\vendor\Chatify\MessagesController] does not exist.

  1. in App\Http\Controllers\vendor\Chatify\MessagesController, change namespace to => App\Http\Controllers\vendor\Chatify;
  2. composer dump-autoload
  3. php artisan config:cache
  4. php artisan cache:clear

from chatify.

munafio avatar munafio commented on May 27, 2024

If you are still facing this issue, please update your Chatify to v1.0.1 which released for issues fixes.

from chatify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.