[Error] ItemDefinition -> Skill about openmu HOT 3 CLOSED

Thanks for your greatly detailled report. 👍🏻

This issue looks strange indeed... My first idea is that it fails to resolve the Skill when loading the GameConfiguration through the JsonObjectLoader, otherwise the SkillId would be null, too.
I will look into it ;)

from openmu.

I can reproduce the error, but didn't find the reason yet.

What I checked:

• The json query contains SkillId and RawSkill elements
• The json result contains the id in SkillId and the correct $ref-element in RawSkill
• The IdReferenceResolver resolves the relevant ItemDefinitions with a Skill assigned in the relevant second pass
• No breakpoint got hit in case the Skill get set from something to null
• In BuyNpcItemAction:
  • The ItemDefinition of the learnable contains the skill in both GameConfiguration.Items and GameConfiguration.Monsters.MerchantStore.Items.Definition and they're the same instance 👍
  • The instance of the MonsterDefinition in the GameConfiguration doesn't match with the one assigned to the npc instance, so e.g. gameContext.Configuration.Monsters.First(npc => npc.Number == 255) == npcDefinition is false.

from openmu.

The issue is most likely caused by the JsonObjectDeserializer. It loads the GameConfiguration in two passes. The first pass fills up references in the IdReferenceResolver, in case there might be any circular references:

        public T Deserialize<T>(TextReader textReader, IReferenceResolver referenceResolver)
        {
            var serializer = new JsonSerializer();
            serializer.ReferenceResolver = referenceResolver;
            serializer.Converters.Add(new BinaryAsHexJsonConverter());

            if (this.AreCircularReferencesExpected)
            {
                // This is a very naive approach to fix references to objects which occur later in the document.
                // The first run just have the task to fills the references in the IdReferenceResolver.
                // Unfortunately there is currently no better way, because we have circular references.
                var jsonString = textReader.ReadToEnd();
                using (var stringReader = new StringReader(jsonString))
                using (var jsonReader = new JsonTextReader(stringReader))
                {
                    serializer.Deserialize<T>(jsonReader);
                }

                textReader = new StringReader(jsonString);
            }

            using (textReader)
            using (var jsonReader = new JsonTextReader(textReader))
            {
                var result = serializer.Deserialize<T>(jsonReader);
                return result;
            }
        }

The issue here is, that the first pass adds an incomplete MonsterDefinition to the IdReferenceResolver, which is then returned at the second pass when resolving it for the MonsterSpawnAreas until the same MonsterDefinition is read again.

from openmu.