Comments (7)
WCAG 4.1.1. states that the site should pass a parsing check (no stray or mismatched tags, for instance) so really any kind of good HTML linting could be a welcome change, but I picked the one the most likely to actually impact a screen reader user.
from web-accessibility.
@ecerta Thanks for the report, I will take a look in a couple of days and will give a better response than this message, I'm insanely busy at the moment!
from web-accessibility.
I have started implementing the check, but it's going to be a very resource intensive functionality.
This is because every time it finds an id
its going to trigger the check and has to do a full document search for duplicated id's.
This is not a performance problem at the moment, but I'm almost sure it's going to be with multiple checks that need to do a full document search.
So if you have any suggestions on how to tackle this problem, I'm all ears.
from web-accessibility.
What if every time any id is found it's added to an array, and then just that array is checked?
from web-accessibility.
That is possible but requires a function that keeps track of those id's that are already in the array and remove them if they changed. I think that would be a complicated function with a logic that will break.
I think I will have to do a refactor for those sort of cases and deal with them separately.
from web-accessibility.
I have tried to implement the logic for duplicated values, in this case for the ID's, but I keep running into problems with the collection of the ID's. So for the next update (0.2.4), this functionality will be held back. I have started a new branch to refactor the whole setup for all the rules, and the feature for duplicated values will be part of the major update (0.3.0). So, for now, This issue will stay open a little longer 😞
from web-accessibility.
This isn't extremely high priority so don't kill yourself over it. If there's a way to do it it'd be a nice perk but if not, there's other ways to make the linter more useful.
from web-accessibility.
Related Issues (20)
- aria-label Warning on aria-hidden elements HOT 1
- deprecated package 'path-is-absolute' HOT 2
- Can you document the tests which are run? HOT 1
- Do we have support for prime-ng tags as well? HOT 1
- Support for Font Awesome <span> technique HOT 1
- Language support for alt texts HOT 2
- ARIA role rules applied too broadly HOT 2
- Support single quotes in html templates HOT 3
- [div onclick="doStuff()"] should trigger an error HOT 2
- Add support for Handlebars
- Highlight button[role="button"] HOT 1
- Accessibility standard HOT 2
- Is there a way to make it work with React JSX? HOT 2
- Don't show alerts on multiple line tag definitions
- Support inside PHP file
- Attribute binding in Angular
- Support Pug
- Support aria-labelledby
- Commented code still shows errors
- alt={`${user}`} shows error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from web-accessibility.