Comments (6)
maybe the same issue occurs in e.g. vscode
yes indeed
from itables.
Thank you @ofir-reich for this report.
Well I know very little of HTML/CSS, so if you don't mind I'll give a few pointers and maybe we will see what we can do with them?
- We import the default CSS for datatables.net at this line:
- I see that datatables has a theme creator at https://datatables.net/manual/styling/theme-creator
- I also find a dark theme at https://parallelcodes.com/jquery-datatable-dark-theme-css-design/ (not tested)
With all this I think we should be able to design a custom style that would be fit for the dark theme (maybe the same issue occurs in e.g. vscode)
But ideally I guess the theme should be dynamic, don't you think so? In that direction I see this SO question which has a mention of the jQueryUI Theme Roller, but I have no idea if that is something we can use here.
from itables.
Is the issue still present with itables==1.0.0
(which uses datatables.net==1.12.1
)?
In my example notebook I see this:
from itables.
In vscode+dark theme switching to itables==1.0.0 made the table be white-letters-on-black-background which makes the table readable. The 'Show', 'Search', and 'Showing' text around the table are still washed out and barely visible. This seems to be an issue also in the colab + dark theme example.
from itables.
Thank you @vttrifonov for the feedback. Currently the CSS used is datatables.net's default theme, which already seems to have improved (probably the improvement comes from the switch from version 1.11.5 to 1.12.1).
Do you think you could propose your own datatables theme? If you do so I'd be happy to propose customisable themes in itables
.
from itables.
I'll close this issue as we are making progress on a similar issue #103 - please follow progresses there.
from itables.
Related Issues (20)
- Download CSV and Excel HOT 2
- Tables in a Streamlit app have a fixed height that does not work well with lengthMenu or search extensions
- Deploy a sample Shiny app that uses ITables HOT 1
- New landing page for conda forge `itables` HOT 4
- Support for the cell range copy to excel HOT 8
- sorry wrong post.. plase delete
- SearchBuilder & Checkboxes HOT 4
- UnicodeDecodeError while set "connected=False" HOT 5
- SearchBuilder Requires DateTime when used with dates. HOT 7
- Support for Polars Struct HOT 2
- Inf loading tables for particular `polars` data frame HOT 10
- Changing the color of buttons in searchBuilder HOT 7
- column_filters does not seem to be working when displaying Pandas Styler object HOT 1
- SearchBuilder picks up   as column name for Pandas styler object but works fine for Pandas dataframe object HOT 2
- Is there a way to make colvis button work without reset_index() HOT 2
- `OverflowError: can't convert negative int to unsigned` HOT 2
- Overflow-x not working properly within an ipywidget.Output widget HOT 5
- [question] Downsampling config options HOT 3
- Missing `conneted=False` and `dt_bundle` support in `to_html_datatable` HOT 4
- issue with conversion of notebook to pdf HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from itables.