itables with Colab dark theme about itables HOT 6 CLOSED

maybe the same issue occurs in e.g. vscode

yes indeed

from itables.

Thank you @ofir-reich for this report.

Well I know very little of HTML/CSS, so if you don't mind I'll give a few pointers and maybe we will see what we can do with them?

• We import the default CSS for datatables.net at this line:
  

  itables/itables/datatables_template.html

  Line 2 in f03c276

  <link rel="stylesheet" type="text/css" href="https://cdn.datatables.net/1.11.3/css/jquery.dataTables.min.css">

• I see that datatables has a theme creator at https://datatables.net/manual/styling/theme-creator
• I also find a dark theme at https://parallelcodes.com/jquery-datatable-dark-theme-css-design/ (not tested)

With all this I think we should be able to design a custom style that would be fit for the dark theme (maybe the same issue occurs in e.g. vscode)

But ideally I guess the theme should be dynamic, don't you think so? In that direction I see this SO question which has a mention of the jQueryUI Theme Roller, but I have no idea if that is something we can use here.

from itables.

Is the issue still present with itables==1.0.0 (which uses datatables.net==1.12.1)?

In my example notebook I see this:

from itables.

In vscode+dark theme switching to itables==1.0.0 made the table be white-letters-on-black-background which makes the table readable. The 'Show', 'Search', and 'Showing' text around the table are still washed out and barely visible. This seems to be an issue also in the colab + dark theme example.

from itables.

Thank you @vttrifonov for the feedback. Currently the CSS used is datatables.net's default theme, which already seems to have improved (probably the improvement comes from the switch from version 1.11.5 to 1.12.1).

Do you think you could propose your own datatables theme? If you do so I'd be happy to propose customisable themes in itables.

from itables.

I'll close this issue as we are making progress on a similar issue #103 - please follow progresses there.

from itables.