Comments (4)
Thanks for the clear reproduction steps. This looks like a pretty simple problem.
To detect whether or not the module has received all of the results, I check to see if the current page of results contains a link to the next page. If there is no next page link, we have received all of the results. This is done using a regex. But sometimes the result XML has:
<types:link href="http://link-to-next-page" rel="next"/>
and other times it has
<types:link rel="next" href="http://link-to-next-page"/>
The regex can't handle the different ordering of tags. I'll switch it to actually parse the XML.
from kijiji-scraper.
That's why you aren't supposed to parse XML/HTML with Regex. See first answer
Jokes aside, you may want to switch to an XML parsing library to avoid stuff like this from occurring in the future, but only if you think it will happen again. Otherwise it's a waste of time. Thanks for the bug fixes!
from kijiji-scraper.
Haha that's right. In this case it seemed good enough, but it looks like I was wrong! Never trust consistency in foreign input.
I'm already using an HTML+XML parsing library (cheerio) for everything else in this module, so it makes sense to use it for this too. Now everything is more consistent.
Try with the latest (6.1.1).
from kijiji-scraper.
Works well!
from kijiji-scraper.
Related Issues (20)
- Random Error:Invalid Kijiji HTML on search results page HOT 5
- Issues with search for services? HOT 7
- Scraper fails to return search results (Kijiji scraper detection + blocking) HOT 23
- Search() with URL HOT 1
- "npm install" fails HOT 9
- MinResults and MaxResults in Search() function implemented improperly, Doesn't allow for getting every listing available. HOT 9
- Consideration for expanding repo to Kijiji API HOT 1
- Kijiji.Ad.Get() Doesn't return to callback HOT 1
- Impossible to fetch ads HOT 5
- Scraper fails to properly scrape some numeric attributes (real numbers) HOT 6
- Missing very new ads when using the Mobile API HOT 15
- Ad #... does not exist HOT 2
- Incorrect Size Attribute For Shoe Category HOT 6
- Category Attributes HOT 5
- Create helper types for enums, and expose expected response attributes
- Package broken: Kijiji-scraper returns no results HOT 5
- Not working HOT 5
- Kijiji Mingle API Issue HOT 11
- How long is a temporary block? I haven't been able to get results since yesterday. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kijiji-scraper.