Giter VIP home page Giter VIP logo

Comments (5)

hazendaz avatar hazendaz commented on July 29, 2024

I was able to flush the above issue with just that update alone so will be completely unrelated to other work I'm pushing through.

from cdi.

hazendaz avatar hazendaz commented on July 29, 2024

Surefire 2.22.0 results in tests running differently. In that case, the weld container appears to remain open longer and multiple get mixed resulting in errors occurring with CDI.current() noting that there are too many weld instances and likely instability. Further JTA gets injected into all these extra containers resulting in errors with 'unique' naming. On their own, each test can be individually run without any errors.

The changes i made to upgrade to junit 5 also exposed this issue. Due to an Eclipse bug with 4.9 release, I have been unable to run tests within eclipse. They fixed the bug in 4.10 but essentially junit 4.12 has to be added back if there are any exceptions to make Eclipse work. I'll likely send a PR for that as a temporarily measure. Further, since I was running command line, I was not paying close enough attention to the number of tests run. It shows them but actually is running nothing. This has to do with need for surefire to have junit added on older surefire. However, doing so also exposes the new conditions.

As it stands, unit tests are effectively not running.

from cdi.

mnesarco avatar mnesarco commented on July 29, 2024

Hi Jeremy,
I am a bit confused with this. What can we do to restore the tests?

from cdi.

hazendaz avatar hazendaz commented on July 29, 2024

Fix coming shortly that will enable 8 of the 13 tests. I was able to figure out a partial solution by changing the junit lifecycle. If I uncomment the JTA tests those will work but cause the non JTA to all fail as the JTA code still gets injected in those cases. While not complete this puts us in a much better position and remains up-to-date.

from cdi.

hazendaz avatar hazendaz commented on July 29, 2024

I can fix to run all tests by simply splitting the test run into two. That will not however resolve the oldest support level we have. If we want to support running those tests as well, I'll have to remove weld-junit and add back the prior support. I can do that but wondering if it's enough to just drop test runs on oldest support level and get all tests otherwise running.

from cdi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.