Comments (6)
Thanks for your feature request @gumulka, I really appreciate you taking the time to submit it.
I'm going to flag this with my colleague @forslund to see if he can give an estimate of how easy / how difficult this would be to implement.
from mycroft-skills.
Thanks for the answer, but the title should be a little bit different.
Unittest should always ensure, that all language directories contain the same files.
let me explain it with an example:
Folder structure 1:
vocab
+-en-us
| +- startsomething.voc
| +- working.voc
+-de-de
| +- startsomething.voc
| +- working.voc
+-it-it
+- startsomething.voc
+- working.voc
^^^^ this is how a folder structure should look like
Folder structure 2:
vocab
+-en-us
| +- start.voc
| +- working.voc
+-de-de
| +- startsomething.voc
| +- working.voc
+-it-it
+- startsomething.voc
+- work.voc
^^^ This can only work in one language and therefore a test should fail, ensuring, that all language directories, if they exist contain the same files. (as in filenames, not content)
Your test only test the english version and ensure, that a file with the content is present and they get somehow parsed. But in different languages, the skills cannot load, because files are missing.
I know how one sometimes changes files or add some to expand the scope of the skill, but when doing so, one should not break the workflow for everyone else, or at least something should tell it to the person/developer.
from mycroft-skills.
Hi, this should be quite easy to implement but there may be sort of a catch 22 here...
(Especially at the moment when the skills need to be accepted into the mycroft-skills repo before the translation server is updated with new phrases.)
I'm also worried that having this as a rejection criteria will be detrimental to language adoption since the skill could be rejected due to a single language not getting updated. Or am I misreading the intent here?
What may be an alternative is to have separate branches for each language mirroring the main one but only updating the commit reference if the language of the branch is complete. This means a working skill would never stop working just because a particular language is lagging behind.
from mycroft-skills.
Maybe don't make it a rejection criteria, but flag a warning to show the user, that there is something missing, or possibly not working correctly.
When writing this issue, I was assuming, that a developer must update the language files, or leave them out completely and not, that all language files are generated by the translation server.
I did not yet understand completely how it works with the translation server, so I'm going to leave it as it is and let you decide what to do or not.
from mycroft-skills.
Maybe only export the translated files to the skill after the skill is fully translated?
from mycroft-skills.
That is the current behaviour. It should only export translations for a Skill if it believes they are complete
from mycroft-skills.
Related Issues (20)
- QuestionsAnswersSkill times out HOT 2
- [Feature] Support Ring HOT 1
- Feature request: Intercom HOT 3
- Remove deprecated values from Skills settingsmeta HOT 7
- Make tagged releases of skills HOT 2
- New Skill: CatchAll Fallback asks to repeat phrase when no intent determined HOT 5
- New Skill: CLI-Command-Skill HOT 5
- [Improvement] Home in languages other than English HOT 1
- New Skill: desktop window tool and dictation HOT 4
- [WIP] Adding interval support to timer HOT 1
- Skill test for updated skills fails, can't extract author
- Skill Meta Editor - icon prefix changed in FA 5
- Removal of mycroft-stock from test config wiping default.yml
- Mycroft-weather doesn't seem to upgrade cleanly HOT 2
- Pulseaudio daemon sometimes fails on startup in CI
- [CI] Docker prunes may clash
- LLM integration skill HOT 1
- New skill: LLM integration HOT 1
- msm update - Error running update_skill on fallback-query: Fast-forwarding not possible HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mycroft-skills.