Comments (3)
Yeah, seems weird, we should definitely handle that better here, not need to override a seemingly intentionally passed variable elsewhere.
from skill-weather.
For a bit of history. It was in the beginning required to provide a language code, then a change was added to set the default lang code based on system config.
Mainly to spare skill creators from typing lang=self.lang
to all translate methods. I think this may still be a good thing to keep in the mycroft-core wrapper to LF
It's not a bug it's a feature .)
from skill-weather.
I believe these have all been removed in the new version so closing.
from skill-weather.
Related Issues (20)
- Bump pyowm to latest version HOT 5
- "great-weather-again" UX timing comment
- Wrong placeholder names in most of localized dialogs HOT 1
- sunset (and i would guess other timedates) wrongly adding tz HOT 13
- "Today" isn't translated with non-english clients in certain cases HOT 1
- Location regex/adapt intent wont work HOT 3
- Use own keys HOT 1
- 'what is temperature' only gives voice information HOT 1
- KeyError: 'timezone' in skill HOT 3
- Asking for sunset time reads the dialog file name
- No icon for "moderate rain" HOT 1
- No translation of the temperature scales HOT 2
- display issue kde bigscreen plasma
- Closing screen hangs on kde HOT 1
- Gui screens not staying up long enough to rea HOT 1
- Sunrise/sunset times are incorrect in UK whilst daylight savings are active (GMT -> BST) HOT 3
- skill.error while asking for the weather HOT 12
- wrong output in build_condition_dialog with non-english language HOT 1
- Error when I ask for the weather of a city in Italian
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skill-weather.