Comments (8)
can you link me to the official documentation?
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-155.md
from ethereum-lists.
Hi Ligi, I'm unaware of the chain ids - is this a de-facto numbering system (ie: 4
is always rinkeby) & if so, can you link me to the official documentation?
Also, the extra mapping would be done on the consumer sides, not ethereum-lists
, so we'd need to discuss more on management (ie: remembering the chain_id values for each testnet) when accepting PRs and such.
from ethereum-lists.
To be honest I struggle to find the "official documentation" on chainId currently - but this is the case - each chain has a Id ..
You see it e.g. mentioned in ethereum/EIPs#155
We can also do the mapping in the scripts - but the mapping should IMHO not be done on the consumers
from ethereum-lists.
To be honest I struggle to find the "official documentation" on chainId currently - but this is the case - each chain has a Id
I understand - all good here 👍 Would be great to find any official documentation (EIP, code comments, whatever) regarding this so we can reference it in a CONTRIBUTING.md
document sometime.
We can also do the mapping in the scripts
My understanding for this repo is for the .json
files to be consumed by an application, and it's just a repo to hold data dumps. Which scripts are you referencing here to do the mapping?
from ethereum-lists.
This script which is currently checking validity:
https://github.com/MyEtherWallet/ethereum-lists/blob/master/src/main/kotlin/ethereum/Main.kt
and generates minimized versions of the json
could also do the mapping.
from ethereum-lists.
Ah, okay, totally missed that.
I'm neutral to this change, but if we do it, we'd need to document the id mapping in CONTRIBUTING.md
:)
from ethereum-lists.
I think this is a good plan. However, for my own sanity, can we somehow put the chain name at the end (which isn't used for validation)?
Eg tokens_1-rop or something.
The other thing is that there are chain IDs of 2 and maybe 3 numbers. So we should probably just do tokens_001 to be safe.
I can also check on how this is operating on v4.
from ethereum-lists.
perhaps it is better in the validation/minimizing step - ideally it is just the number - so you can directly load - without using a wildcard or use the mapping - just "tokens-${chainid}.json"
I will prepare for this a PR. PS: there is another one open: https://github.com/MyEtherWallet/ethereum-lists/pulls
from ethereum-lists.
Related Issues (20)
- [Etherscan.io 10/10/2020 14:57:32] I, hereby verify that I am the owner/creator of the address [0x8e870d67f660d95d5be530380d0ec0bd388289e1] HOT 3
- Add EUM ICON HOT 2
- Create 0xbc16da9df0a22f01a16bc0620a27e7d6d6488550.json #1644 HOT 1
- Fully remove old token HOT 2
- Please ADD 'AIRDROP' to default token list HOT 2
- Issue adding a token HOT 1
- Problem with Pool Request processing HOT 6
- Does HOT 1
- Token Name: TFI HOT 2
- H
- Token info merged into github 6 months ago but doesn't appear in MEW interface HOT 2
- Double $based HOT 2
- 0xeA7aA1eDd21735A5ab05EE3E90869016191e274E token symbol undefined HOT 1
- 54lfXC HOT 3
- Pakorn
- configuration HOT 2
- Token merged but does not appear into mew interface HOT 2
- This scam project is kind a new style. HOT 1
- Я делюсь с вами файлом ethereum_evm_illust rated
- 0x6Bb39276bA115B89F97433BF12307CcBA2d575Dc HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ethereum-lists.