Comments (5)
Interesting! It looks like @r-e-d added this in e7a4645. But I don't see a rationale for that conditional. Unless there are objections, I think we should remove the conditional.
from cppclean.
In a project, we include the ".hxx" at the end of the ".h". And as the ".hxx" contains templated code, it produces an erroneous "Header does not need to be #included; use a forward declaration instead".
This line is used to ignore ".hxx" for this warning.
from cppclean.
Could that behaviour be made optional, instead of default? Only it's not documented, and very surprising. I'd be happy to submit a PR for this.
Alternatively, there could be a mechanism to silence particular warnings, either through a flag to cppclean or code annotations.
Unfortunately, as it is, it makes cppclean essentially unusable for projects using ".cxx/.hxx" file extensions.
from cppclean.
I guess this line can be changed into :
if filename != self.filename + 'xx':
This way it will only prevent a warning if foo.h include foo.hxx (and not regress my use case).
from cppclean.
Or perhaps make it an option that can be configured?
from cppclean.
Related Issues (20)
- Include tests in source tarballs
- test/unicode.h licensed under GPL-2.0 HOT 2
- Python 3.7: RuntimeError: generator raised StopIteration HOT 3
- False-positive when using mixed folder separator style (backslash and forward slash). HOT 1
- "Exception while processing 'myheaderfile.hpp': unexpected token: Token(u'true', xxx, yyy)"
- parsing error: Token(u'#include <set>\\\n', xxx, yyy)
- parsing error: (Token(u'::', xxx, yyy), [], [Token(u'B', zzz, bbb)]) HOT 1
- False positive when includes are not together in the .cpp file. HOT 1
- Invalid "... not found in any directly included header" HOT 2
- Issue with include .hxx file
- which versions of C++ are supported? HOT 1
- Does this also support C or just C++?
- RuntimeError: generator raised StopIteration for a very simple code
- Y'all ever heard of paths having spaces?
- Do I use the program correctly? (Windows)
- 0.13: pytest is failing in 7 units HOT 1
- False positive : does not need to be #included with fields of structure
- False positive when calling a macro from within another macro
- Missing Feature ... WishList item
- False positive "should not #include C++ source file" for CMake's AUTOMOC files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cppclean.