Crash in _get_method on invalid/incomplete code about cppclean HOT 5 CLOSED

I'm not sure that we want to handle incomplete code.

from cppclean.

I agree with @r-e-d. One of the documented "non-goals" in the readme is "Handling invalid C++ source gracefully".

from cppclean.

Since cppclean seems to stop processing when running across such a problem usability is suffering. Due to incomplete include search PATHs, shortcoming during preprocessing(?) code may look incomplete - while it is not in the real world use-case.

from cppclean.

cppclean does not do preprocessing so yes we need to handle some 'invalid' code. But in this case, I don't see how we can hit this crash with a valid input. Do you have a sample where we hit this case with a valid source ?

Also I think cppclean only stops parsing the current file when crashing, it should continue to analyse the other files. But maybe I'm wrong about that and in that case we should see if we can fix it.

from cppclean.

@amai2012, that is a good point. I'll take a look.

from cppclean.