Update Components Across Go Packages about react HOT 8 CLOSED

Thanks for raising this here @norunners - as I mentioned in the Slack channel, I will take a look when I get a minute and revert back.

from react.

Sounds good, I cut this issue for transparency in case other folks encounter the same issue.

from react.

This appears to be a GopherJS compiler issue... because after a cursory glance it doesn't even start running main...

from react.

@norunners this is actually related to gopherjs/gopherjs#414

For the two branches where you see things "failing" the code does not actually compile because of an import cycle. If you run go build in your main package you'll see something like:

import cycle not allowed
package github.com/norunners/helloreact
        imports github.com/norunners/helloreact/app
        imports github.com/norunners/helloreact/nav
        imports github.com/norunners/helloreact/app

gopherjs serve doesn't report the problem; like gopherjs build it should (but doesn't because of the linked issue).

Also, as far as updating components in different packages is concerned, I don't think there's any issues there, no least because the examples showcase does this repeatedly.

So I'd be tempted to close this issue... but will wait to hear back from you first.

from react.

Thank you for investigating this, if this is the case we can put an extra gotcha in the docs about circular dependencies.

Tonight, I'll do a quick proof of concept of putting the callback behavior interface in a third "share" Go package to verify that is the root cause.

from react.

Thank you for investigating this, if this is the case we can put an extra gotcha in the docs about circular dependencies.

No problem.

Sorry if I wasn't clear in my previous message. It's not a gotcha (with the React bindings); it's a bug in GopherJS that the circular dependency isn't reported to you as an error in your code.

from react.

Works as expected! As you mentioned in the related issue, this is something gopherjs serve should surface as an error. Feel free to close this issue.

from react.

Great. Closing this issue therefore

from react.