Comments (4)
$ find . -name "*dynamic*.cc" | xargs grep delete
./cld2_dynamic_data_tool.cc: delete header->tableHeaders;
./cld2_dynamic_data_tool.cc: delete header;
./cld2_dynamic_data_loader.cc: delete header;
./cld2_dynamic_data_loader.cc: delete header;
./cld2_dynamic_data_loader.cc: delete tableHeaders;
./cld2_dynamic_data_loader.cc: delete header;
./cld2_dynamic_data_loader.cc: delete tableHeaders;
./cld2_dynamic_data_loader.cc: delete((*scoringTables)->unigram_compat_obj);
// tableSummaries[0] from loadDataFile
./cld2_dynamic_data_loader.cc: delete(*scoringTables);
./cld2_dynamic_data_loader.cc: delete header->tableHeaders;
./cld2_dynamic_data_loader.cc: delete header;
I think all we need to fix here is the tableHeaders deletion work.
Original comment by [email protected]
on 15 May 2014 at 4:37
from cld2.
This is fixed in r161:
https://code.google.com/p/cld2/source/detail?r=161
I've run all the unit tests again, and confirmed that this fixes the issue in
the Chromium build system as well.
Original comment by [email protected]
on 16 May 2014 at 10:36
- Changed state: Verified
from cld2.
For posterity:
* This doesn't affect the binary file format at all. Previously generated dumps
will still work properly.
* Because the objects pointed to by the pointer were structs instead of class
instances, the use of delete and delete[] should be exactly equivalent (i.e.,
there is no destructor to call on each element of the array, so there is
nothing gained by adding the [])
This is purely a compiler-happiness change.
Original comment by [email protected]
on 16 May 2014 at 11:45
from cld2.
Also for posterity, I think what happened is that Chromium's build system
finally absorbed this change:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=29185
Original comment by [email protected]
on 16 May 2014 at 11:46
from cld2.
Related Issues (20)
- Consider declaring dynamic data methods unconditionally HOT 3
- CLD2 result chunk vector omits portions of input file HOT 6
- Dynamic data loading should not use iostream HOT 5
- Windows build fails: undeclared identifier 'close' HOT 6
- Support mmap-ing dynamic data on win32 HOT 5
- Build warning on Windows with clang HOT 2
- Eliminate redundancy and/or simplify default case for compiling unittest_data.h HOT 4
- Missing include in cld2_dynamic_data_loader.cc HOT 1
- cld2_dynamic_data.cc and cld2_dynamic_data_loader.cc problems on Win32 HOT 10
- Enable dynamic data for 20141015 release HOT 1
- New GCC 5.0 hits problem with narrowing in list-initializers
- CLD should check result of "new" in all use cases HOT 1
- please use CFLAGS CXXFLAGS CPPFLAGS and LDFLAGS HOT 3
- please provide a SONAME HOT 13
- cld2 testsuite failures HOT 3
- Compilation issues in Visual Studio
- Compilation failure on VS2015 on Windows
- Check in tools for generating generated_* files HOT 1
- Add armv8-a support HOT 5
- new code location? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cld2.