Comments (7)
Manually verified that all unit tests pass with
cld2_generated_quadchrome0122_16.cc.
Original comment by [email protected]
on 3 Mar 2014 at 3:32
from cld2.
Also TBD: Null-out all kScoringtables members in the call to unloadData.
Original comment by [email protected]
on 3 Mar 2014 at 3:42
from cld2.
Attaching a patch for dealing with the data in an externally-managed mmap. Unit
tests have been updated to re-run in mmap-based dynamic mode as well as
file-based dynamic mode, and all pass.
Original comment by [email protected]
on 3 Mar 2014 at 5:10
Attachments:
from cld2.
Patch committed as r153
Original comment by [email protected]
on 4 Mar 2014 at 10:30
from cld2.
The patch takes care of nulling out the fields in kScoringtables.
Still TODO:
* Use the newly-added constants in the table classes to avoid hardcoding sizes
* Remove all FIXME and TODO comments added by [email protected] as well
Original comment by [email protected]
on 4 Mar 2014 at 10:33
from cld2.
Here we go, this patch switches over to use the constants. I also added the
constants into the 0122 files that were missing them, and I've compiled and run
all tests in all the shell scripts. Everything works, and the data files are
perfect binary matches before and after the patch. This looks correct to me,
and since all tests are passing I'm going to go ahead and submit (no functional
changes here for CLD2).
There are still a few FIXMEs but they revolve around different things, like not
relying on bitpacking of underlying structures. This isn't a problem right now,
and we can push it off indefinitely (possibly forever).
Original comment by [email protected]
on 11 Mar 2014 at 12:40
Attachments:
from cld2.
Patch committed as r154
Original comment by [email protected]
on 11 Mar 2014 at 12:42
- Changed state: Fixed
from cld2.
Related Issues (20)
- Consider declaring dynamic data methods unconditionally HOT 3
- CLD2 result chunk vector omits portions of input file HOT 6
- Dynamic data loading should not use iostream HOT 5
- Windows build fails: undeclared identifier 'close' HOT 6
- Support mmap-ing dynamic data on win32 HOT 5
- Build warning on Windows with clang HOT 2
- Eliminate redundancy and/or simplify default case for compiling unittest_data.h HOT 4
- Missing include in cld2_dynamic_data_loader.cc HOT 1
- cld2_dynamic_data.cc and cld2_dynamic_data_loader.cc problems on Win32 HOT 10
- Enable dynamic data for 20141015 release HOT 1
- New GCC 5.0 hits problem with narrowing in list-initializers
- CLD should check result of "new" in all use cases HOT 1
- please use CFLAGS CXXFLAGS CPPFLAGS and LDFLAGS HOT 3
- please provide a SONAME HOT 13
- cld2 testsuite failures HOT 3
- Compilation issues in Visual Studio
- Compilation failure on VS2015 on Windows
- Check in tools for generating generated_* files HOT 1
- Add armv8-a support HOT 5
- new code location? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cld2.