Windows Alternative to iltorb about brotli-webpack-plugin HOT 4 CLOSED

Thanks for your feedback!

There's two main problems right now:

1. during my quick tests, brotli,js was at average 3x slower than iltorb
2. brotli.js exposes only synchronous interface (due to emscripten-generated code)

While the first one could be solved using optionalDependencies and runtime require()s, the secound could be tricky and degrade overall webpack performance.

I'll look into it soon, but PRs are welcome :)

from brotli-webpack-plugin.

@unsafecode sorry for the delay! I've created PR #5 with conditional logic.

Could you please try it on your Windows setup with npm install --save-dev brotli-webpack-plugin@next and leave feedback?

from brotli-webpack-plugin.

@mynameiswhm Nice, it works! I'd just add in the docs the need of a peerDep for brotli, so to state it clearly.

from brotli-webpack-plugin.

@unsafecode both iltorb and brotli is now included in optionalDependencies, so npm will try to install all of them, but fail silently if something goes wrong. Worst case scenario: both installations failed, but it's hard to imagine that for brotli.js, which is precompiled emscripten port.

from brotli-webpack-plugin.