Comments (3)
I think it's ok to make this non-default and require users to opt in on a specific call by, for example, retrieving a different kind of Peer
than normal (a RetryingPeer
or something).
from anemo.
One more thought, while one could imagine implementing this at the application level by adding retries, that is worse than the network stack doing this because the application doesn't necessarily have visibility into the state of underlying connections. So maybe I'm retrying every 1s but the peer connects after 100ms, and then I'm just sitting around waiting for 900ms until the next retry. Whereas if this is queued in the network stack then as soon as the connection happens, the request can immediately send.
This is indeed a deficiency of the current P2pNetwork::send
implementation in narwhal today.
from anemo.
Closed by MystenLabs/sui#5277
from anemo.
Related Issues (14)
- improve handling of dns resolution and ipv6 address when bound to an ipv4 socket HOT 1
- FR: Timeout configs with more granularity
- Delete one of `Response::into_inner` or `Response::into_body`
- use an audited HKDF for deriving the quic reset key HOT 2
- FR: more detailed errors
- FR: anemo command line tool HOT 1
- Support sending child RPCs within an RPC handler HOT 1
- Improve errors/logging when hitting response frame limits
- Implement mock servers for unit tests HOT 3
- Implement native support for RPC timeouts HOT 3
- Implement authorization support HOT 2
- Add a way to get peer ID from Status for RPC response error HOT 1
- FR: Add support for request rate and inflight limiting
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from anemo.