Giter VIP home page Giter VIP logo

Comments (3)

aschran avatar aschran commented on June 27, 2024

I think it's ok to make this non-default and require users to opt in on a specific call by, for example, retrieving a different kind of Peer than normal (a RetryingPeer or something).

from anemo.

aschran avatar aschran commented on June 27, 2024

One more thought, while one could imagine implementing this at the application level by adding retries, that is worse than the network stack doing this because the application doesn't necessarily have visibility into the state of underlying connections. So maybe I'm retrying every 1s but the peer connects after 100ms, and then I'm just sitting around waiting for 900ms until the next retry. Whereas if this is queued in the network stack then as soon as the connection happens, the request can immediately send.

This is indeed a deficiency of the current P2pNetwork::send implementation in narwhal today.

from anemo.

bmwill avatar bmwill commented on June 27, 2024

Closed by MystenLabs/sui#5277

from anemo.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.